Skip to content

Commit bfc8962

Browse files
committed
Update workspace
1 parent 091edc0 commit bfc8962

File tree

5 files changed

+35
-25
lines changed

5 files changed

+35
-25
lines changed

WORKSPACE

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,15 @@ load("prereqs.bzl", "rules_android_prereqs")
66

77
rules_android_prereqs(dev_mode = True)
88

9-
load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
10-
rules_java_dependencies()
11-
129
load("@bazel_features//:deps.bzl", "bazel_features_deps")
1310
bazel_features_deps()
1411

12+
load("@rules_cc//cc:extensions.bzl", "compatibility_proxy_repo")
13+
compatibility_proxy_repo()
14+
15+
load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
16+
rules_java_dependencies()
17+
1518
# note that the following line is what is minimally required from protobuf for the java rules
1619
# consider using the protobuf_deps() public API from @com_google_protobuf//:protobuf_deps.bzl
1720
load("@com_google_protobuf//bazel/private:proto_bazel_features.bzl", "proto_bazel_features") # buildifier: disable=bzl-visibility

defs.bzl

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ def rules_android_workspace():
5757
# These technically aren't needed, but the protobuf version pulled
5858
# in by these older deps has compatibility issues with the newer
5959
# protobuf runtimes.
60-
"com.google.protobuf:protobuf-java:4.31.1",
61-
"com.google.protobuf:protobuf-java-util:4.31.1",
60+
"com.google.protobuf:protobuf-java:4.33.1",
61+
"com.google.protobuf:protobuf-java-util:4.33.1",
6262
],
6363
repositories = [
6464
"https://maven.google.com",
@@ -94,8 +94,8 @@ def rules_android_workspace():
9494
"jakarta.inject:jakarta.inject-api:2.0.1",
9595
"junit:junit:4.13.2",
9696
"com.beust:jcommander:1.82",
97-
"com.google.protobuf:protobuf-java:4.31.1",
98-
"com.google.protobuf:protobuf-java-util:4.31.1",
97+
"com.google.protobuf:protobuf-java:4.33.1",
98+
"com.google.protobuf:protobuf-java-util:4.33.1",
9999
"com.google.code.findbugs:jsr305:3.0.2",
100100
"androidx.databinding:databinding-compiler:8.7.0",
101101
"org.ow2.asm:asm:9.6",
@@ -149,8 +149,8 @@ def rules_android_workspace():
149149
"com.google.code.gson:gson:2.10.1", # bazel worker api
150150
"com.google.errorprone:error_prone_annotations:2.23.0", # bazel worker api
151151
"com.google.guava:guava:33.0.0-jre", # bazel worker api
152-
"com.google.protobuf:protobuf-java:4.27.2", # bazel worker api
153-
"com.google.protobuf:protobuf-java-util:4.27.2", # bazel worker api
152+
"com.google.protobuf:protobuf-java:4.33.1", # bazel worker api
153+
"com.google.protobuf:protobuf-java-util:4.33.1", # bazel worker api
154154
"junit:junit:4.13.2", # bazel worker api
155155
"org.mockito:mockito-core:5.4.0", # bazel worker api
156156
"com.google.truth:truth:1.4.0", # bazel worker api
@@ -170,12 +170,8 @@ def rules_android_workspace():
170170
gazelle_dependencies()
171171
# gazelle:repository go_repository name=org_golang_x_xerrors importpath=golang.org/x/xerrors
172172

173-
go_repository(
174-
name = "org_golang_google_protobuf",
175-
importpath = "google.golang.org/protobuf",
176-
sum = "h1:g0LDEJHgrBl9N9r17Ru3sqWhkIx2NB67okBHPwC7hs8=",
177-
version = "v1.31.0",
178-
)
173+
# Note: org_golang_google_protobuf is now set up by go_rules_dependencies()
174+
# with proper patches for newer protobuf versions.
179175

180176
go_repository(
181177
name = "com_github_google_go_cmp",

examples/basicapp/.bazelrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ common --tool_java_runtime_version=17
1313
# Workaround for a rules_java + bazel < 8.3.0 issue. It should only be relevant
1414
# for bazel@HEAD and rolling releases.
1515
# https://github.com/bazelbuild/bazel/pull/26119
16-
common --repositories_without_autoloads=bazel_features_version,bazel_features_globals
16+
common --repositories_without_autoloads=bazel_features_version,bazel_features_globals,cc_compatibility_proxy
1717

1818
# Newer versions of protobuf require downstream transitive projects to set C++ language version flags.
1919
common:linux --cxxopt=-std=c++17

examples/basicapp/WORKSPACE

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,16 @@ local_repository(
99
load("@rules_android//:prereqs.bzl", "rules_android_prereqs")
1010
rules_android_prereqs()
1111

12+
load("@bazel_features//:deps.bzl", "bazel_features_deps")
13+
bazel_features_deps()
14+
15+
load("@rules_cc//cc:extensions.bzl", "compatibility_proxy_repo")
16+
compatibility_proxy_repo()
17+
1218
##### rules_java setup for rules_android #####
1319
load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
1420
rules_java_dependencies()
1521

16-
load("@bazel_features//:deps.bzl", "bazel_features_deps")
17-
bazel_features_deps()
18-
1922
# note that the following line is what is minimally required from protobuf for the java rules
2023
# consider using the protobuf_deps() public API from @com_google_protobuf//:protobuf_deps.bzl
2124
load("@com_google_protobuf//bazel/private:proto_bazel_features.bzl", "proto_bazel_features") # buildifier: disable=bzl-visibility

prereqs.bzl

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,21 @@ load("//bzlmod_extensions:com_android_dex.bzl", _com_android_dex_archive = "com_
2121
def rules_android_prereqs(dev_mode = False):
2222
"""Downloads prerequisite repositories for rules_android."""
2323

24+
maybe(
25+
http_archive,
26+
name = "bazel_features",
27+
sha256 = "a660027f5a87f13224ab54b8dc6e191693c554f2692fcca46e8e29ee7dabc43b",
28+
strip_prefix = "bazel_features-1.30.0",
29+
url = "https://github.com/bazel-contrib/bazel_features/releases/download/v1.30.0/bazel_features-v1.30.0.tar.gz",
30+
)
31+
2432
maybe(
2533
http_archive,
2634
name = "rules_java",
2735
urls = [
28-
"https://github.com/bazelbuild/rules_java/releases/download/9.0.3/rules_java-9.0.3.tar.gz",
36+
"https://github.com/bazelbuild/rules_java/releases/download/9.2.0/rules_java-9.2.0.tar.gz",
2937
],
30-
sha256 = "865b3d334bd0f769587737447410d8042d6a95134cc45be5380805fdbacd7152",
38+
sha256 = "2f822fbc33b99de5bbeaceada4be2bd3bb5c8da80e2f7462a9d300c8fc312f11",
3139
)
3240

3341
maybe(
@@ -45,8 +53,8 @@ def rules_android_prereqs(dev_mode = False):
4553
url = "https://mirror.bazel.build/bazel_android_tools/android_tools_pkg-0.31.0.tar",
4654
)
4755

48-
RULES_JVM_EXTERNAL_TAG = "6.7"
49-
RULES_JVM_EXTERNAL_SHA = "a1e351607f04fed296ba33c4977d3fe2a615ed50df7896676b67aac993c53c18"
56+
RULES_JVM_EXTERNAL_TAG = "6.9"
57+
RULES_JVM_EXTERNAL_SHA = "3c41eae4226a7dfdce7b213bc541557b8475c92da71e2233ec7c306630243a65"
5058
maybe(
5159
http_archive,
5260
name = "rules_jvm_external",
@@ -55,8 +63,8 @@ def rules_android_prereqs(dev_mode = False):
5563
url = "https://github.com/bazelbuild/rules_jvm_external/releases/download/%s/rules_jvm_external-%s.tar.gz" % (RULES_JVM_EXTERNAL_TAG, RULES_JVM_EXTERNAL_TAG),
5664
)
5765

58-
PROTOBUF_VERSION = "33.0"
59-
PROTOBUF_HASH = "cbc536064706b628dcfe507bef386ef3e2214d563657612296f1781aa155ee07"
66+
PROTOBUF_VERSION = "33.1"
67+
PROTOBUF_HASH = "fda132cb0c86400381c0af1fe98bd0f775cb566cb247cdcc105e344e00acc30e"
6068
maybe(
6169
http_archive,
6270
name = "com_google_protobuf",

0 commit comments

Comments
 (0)