Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverge support breaks when test has its own dependency on org.jacoco.* #202

Open
Silic0nS0ldier opened this issue Jul 25, 2024 · 1 comment
Labels
P3 We're not considering to work on this, but happy to review a PR. (No assignee)

Comments

@Silic0nS0ldier
Copy link

As a coverage tool, it is highly unlikely that a library will include a genuine dependency on org.jacoco.*. However;

@fmeum
Copy link
Contributor

fmeum commented Jul 25, 2024

We actually ran into this with Jazzer, which has a legitimate need to depend on JaCoCo during regular execution. Shading helped here: https://github.com/CodeIntelligenceTesting/jazzer/blob/main/third_party/jacoco_internal.BUILD

Bazel has a built-in capability to detect classpath duplication, which I recently wired up to some extent. You could take a look at the test in bazelbuild/bazel@417c6b8#diff-61be5294c014a8b30530f4e0801697cf6d8c1181d8e4400164b62ef00c2be0d5 and see whether this setup catches the issue.

@hvadehra hvadehra added the P3 We're not considering to work on this, but happy to review a PR. (No assignee) label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering to work on this, but happy to review a PR. (No assignee)
Projects
None yet
Development

No branches or pull requests

3 participants