Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding @bazel_tools//tools/java/runfiles to rules_java #46

Open
fmeum opened this issue Nov 27, 2021 · 1 comment
Open

Adding @bazel_tools//tools/java/runfiles to rules_java #46

fmeum opened this issue Nov 27, 2021 · 1 comment
Labels
P3 We're not considering to work on this, but happy to review a PR. (No assignee)

Comments

@fmeum
Copy link
Contributor

fmeum commented Nov 27, 2021

Would you welcome a PR that adds the Bazel Java runfiles library, which is available at @bazel_tools//tools/java/runfiles, to rules_java? According to the Starlark "Deploying rules" guide, it should be available at @rules_java//java/runfiles.

I am specifically asking this because I found an issue with the version of the runfiles libraries currently bundled with Bazel and am wondering about how future improvements to these libraries could be published so that users on older Bazel versions could still use them. Especially now that modules exist, rules_java is bound to get far more commonly used and would be a more natural place for modules to get the runfiles library from than @bazel_tools.

@comius comius added the P3 We're not considering to work on this, but happy to review a PR. (No assignee) label Feb 4, 2022
@comius
Copy link
Collaborator

comius commented Feb 4, 2022

It makes sense to put @bazel_tools//tools/java/runfiles here, because it's only needed by Java projects.

We'd actually want @bazel_tools removed one day, so it's a welcome change. The tricky part is probably how to add it here and then remove it from @bazel_tools. Not to have duplicated code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering to work on this, but happy to review a PR. (No assignee)
Projects
None yet
Development

No branches or pull requests

2 participants