From 1036a4d02bc7864da98e9caa96238e70695c9d1e Mon Sep 17 00:00:00 2001 From: Jason Bedard Date: Sat, 18 May 2024 21:30:23 -0700 Subject: [PATCH] fix: remove bzlmod pip.parse() annotations attribute (#1808) This change removes unused attributes from the `bzlmod` APIs cleaning up the docs and src code. --------- Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com> --- CHANGELOG.md | 2 ++ python/private/bzlmod/pip.bzl | 3 +++ 2 files changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 241dce4870..af97798a2b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -42,6 +42,8 @@ A brief description of the categories of changes: also now handled correctly, stabilizing the implementation. * (gazelle) Fix Gazelle failing on Windows with "panic: runtime error: invalid memory address or nil pointer dereference" +* (bzlmod) remove `pip.parse(annotations)` attribute as it is unused and has been + replaced by whl_modifications. ### Added * (rules) Precompiling Python source at build time is available. but is diff --git a/python/private/bzlmod/pip.bzl b/python/private/bzlmod/pip.bzl index 80ee852573..aa70810549 100644 --- a/python/private/bzlmod/pip.bzl +++ b/python/private/bzlmod/pip.bzl @@ -585,6 +585,9 @@ The labels are JSON config files describing the modifications. # don't allow users to override it. attrs.pop("repo_prefix") + # annotations has been replaced with whl_modifications in bzlmod + attrs.pop("annotations") + return attrs def _whl_mod_attrs():