Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: With control example does not work on Docs #51

Open
VladimirAfanasievFS opened this issue May 9, 2022 · 6 comments
Open

BUG: With control example does not work on Docs #51

VladimirAfanasievFS opened this issue May 9, 2022 · 6 comments

Comments

@VladimirAfanasievFS
Copy link

VladimirAfanasievFS commented May 9, 2022

when use @storybook/addon-essentials docs page has loop update
I have added consol.log("loop") to show the problem

loop
image

@bhishp
Copy link
Collaborator

bhishp commented May 10, 2022

Interesting, thanks for raising this issue. I am away for a few weeks now with limited internet access so I can't investigate in detail, but if anyone gets an opportunity to do some deeper digging or raise a PR, I should be able to get it merged/deployed.

I notice that this code block was added in the following PR: https://github.com/bhishp/storybook-formik/pull/38/files#diff-0b5adbfe7b36e4ae2f479291e20152e33e940f7f265162d77f40f6bdb5da7405R51, in order to support controls, @jlaramie you able to take a look back over your change?

@solace
Copy link

solace commented May 25, 2022

I have observed this issue as well and a workaround is to use inlineStories: false for docs.

eg.

  parameters: {
    docs: {
      inlineStories: false,
      iframeHeight: 300,
    },
  },

Note that there are drawbacks to this rendering method: https://storybook.js.org/docs/react/writing-docs/docs-page#inline-stories-vs-iframe-stories

@jlaramie
Copy link
Contributor

I will see about looking over this. Just saw this on my side.

@diego-oikos
Copy link

The same situation is happening in my codebase. I did a test and, if I use a <Formik> component instead of using the withFormik hook, the loop disappears. Also tried @solace 's workaround, and the loop stops happening. Please let me know if I can help further.

@sergei-maertens
Copy link

Is there any progress on this issue? Can we help in some way? I've just noticed this was crashing my browser too. The inlineStories: false workaround works, but I'd prefer to get to the root cause for this.

sergei-maertens added a commit to open-formulieren/formio-builder that referenced this issue Apr 11, 2023
@bhishp
Copy link
Collaborator

bhishp commented Apr 17, 2023

Is there any progress on this issue? Can we help in some way? I've just noticed this was crashing my browser too. The inlineStories: false workaround works, but I'd prefer to get to the root cause for this.

I'm afraid that I don't have a lot of time to maintain this project right now, but happy to accept PRs. As mentioned above, there seemed to be a previous PR that may be related here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants