fix install script for Ubuntu 20.04

- `mkdir` shouldn't fail, so that `set -e` can be used to debug the script.
- remove `sudo` as the script only accept UID 0
- update `nodejs` to v12

Author: pkeroulas

README.md

@@ -5,7 +5,7 @@ This is a basic tool, intended to provide a reference example for implementors a
 
 ## Getting Started
 
-The following instructions have been tested on Ubuntu 16.04, but may work for other operating systems.
+The following instructions have been tested on Ubuntu 20.04, but may work for other operating systems.
 
 ```
 $ git clone https://github.com/bbc/nmos-web-router.git

install.sh

@@ -1,4 +1,5 @@
 #!/bin/bash
+
 if [ "$EUID" -ne 0 ]
   then echo "Please run as root"
   exit
@@ -11,15 +12,15 @@ apt-get install -y curl git
 DIR=$(pwd)
 
 # Add apt repositories for NodeJS and Yarn
-curl -sL https://deb.nodesource.com/setup_8.x | sudo -E bash -
-curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add -
-echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list
+curl -sL https://deb.nodesource.com/setup_12.x | -E bash -
+curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -
+echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list
 
 # Install NodeJS and Yarn
 apt-get update && apt-get install -y nodejs yarn
 
 # Create and cd into the directory required to run the provision_node script
-mkdir /home/vagrant
+mkdir -p /home/vagrant
 cd /home/vagrant
 
 # Provision a Node
@@ -31,14 +32,14 @@ APT_TOOL='apt-get -o Debug::pkgProblemResolver=yes --no-install-recommends -y'
 
 # All service are run as an ipstudio user
 useradd ipstudio
-mkdir /home/ipstudio
+mkdir -p /home/ipstudio
 chown -R ipstudio /home/ipstudio
 
 sed -i 's/# deb-src/deb-src/' /etc/apt/sources.list
 apt-get update
-apt-get install python3-pip python3-mock devscripts debhelper equivs python3-setuptools python-stdeb python3 tox -y
-
-cd /home/vagrant
+apt-get install python3-pip python3-mock devscripts debhelper equivs \
+    dh-python python-setuptools python-all apache2-dev dh-systemd \
+    python3-setuptools python-stdeb python3 tox -y
 
 git clone https://github.com/bbc/nmos-common.git
 git clone https://github.com/bbc/nmos-reverse-proxy.git
@@ -55,23 +56,23 @@ make dsc
 mk-build-deps --install deb_dist/nmosreverseproxy_*.dsc --tool "$APT_TOOL"
 make deb
 dpkg -i dist/python3-nmosreverseproxy_*_all.deb
-sudo apt-get -f -y install
+apt-get -f -y install
 
 cd /home/vagrant/nmos-mdns-bridge
 sed -i "s/, python3-nmoscommon//" stdeb.cfg
 make dsc
 mk-build-deps --install deb_dist/mdnsbridge_*.dsc --tool "$APT_TOOL"
 make deb
 dpkg -i dist/python3-mdnsbridge_*_all.deb
-sudo apt-get -f -y install
+apt-get -f -y install
 
 cd /home/vagrant/nmos-node
 sed -i "s/, python3-nmoscommon//" stdeb.cfg
 make dsc
 mk-build-deps --install deb_dist/nodefacade_*.dsc --tool "$APT_TOOL"
 make deb
 dpkg -i dist/python3-nodefacade_*_all.deb
-sudo apt-get -f -y install
+apt-get -f -y install
 
 service apache2 restart
 

src/ips-nmos-api/README.md

@@ -16,7 +16,7 @@ Installation
 ------------
 
 ```
-npm i -s bbc/ips-nmos-api
+npm i -s src/ips-nmos-api
 ```
 
 or