Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last few milliseconds getting clipped in zoomview. #556

Open
vivekd95 opened this issue Nov 25, 2024 · 4 comments
Open

Last few milliseconds getting clipped in zoomview. #556

vivekd95 opened this issue Nov 25, 2024 · 4 comments

Comments

@vivekd95
Copy link

vivekd95 commented Nov 25, 2024

image

As you can see the zoomview is not rendered for the whole duration. The view is clipped for the last few ms, which indirectly affects the user experience as the segment is being shown as somewhat hidden. Do provide your opinion.

@chrisn
Copy link
Member

chrisn commented Nov 28, 2024

Segments are not restricted to the audio duration, so it's possible for segments to extend beyond the end of the audio.

In your example, what does instance.player.getDuration() return, and what is the end time of the segment?

@vivekd95
Copy link
Author

vivekd95 commented Dec 2, 2024

In my example, the duration is 619.652367s. Meanwhile, the start and end times of the segment are 617.653s and 619.653s, respectively.

@chrisn
Copy link
Member

chrisn commented Dec 2, 2024

We could make it so that the waveform view takes into account the segment times, not only the audio duration?

@vivekd95
Copy link
Author

vivekd95 commented Dec 5, 2024

Yeah. This might work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants