Reintroduce eslint and fix some minor errors and unused require-d statements.

Author: thom4parisot

Diff for: .eslintignore

@@ -0,0 +1,2 @@
+lib/algorithms/*.js
+!lib/algorithms/default.js

Diff for: .eslintrc

@@ -0,0 +1,24 @@
+{
+    "env": {
+        "node": true
+    },
+    "extends": "eslint:recommended",
+    "rules": {
+        "indent": [
+            "error",
+            2
+        ],
+        "linebreak-style": [
+            "error",
+            "unix"
+        ],
+        "quotes": [
+            "error",
+            "single"
+        ],
+        "semi": [
+            "error",
+            "always"
+        ]
+    }
+}

Diff for: .eslintrc.json

@@ -1,6 +1,5 @@
 'use strict';
 
-var path = require('path');
 var extend = require('xtend');
 var defaultAlgorithm = require('./algorithms/default.js');
 
@@ -44,6 +43,7 @@ Slayer.prototype = {
    * @param i {Number}
    * @returns {Number}
    */
+  // eslint-disable-next-line no-unused-vars
   getItem: function getItem(item, originalItem, i){
     return item;
   },
@@ -70,7 +70,7 @@ Slayer.prototype = {
    * Configures the internal filters of a slayer instance
    */
   configureFilters: function configureFilters(config){
-    if (typeof config.minPeakHeight !== 'number' || config.minPeakHeight === NaN){
+    if (typeof config.minPeakHeight !== 'number' || isNaN(config.minPeakHeight)){
       throw new TypeError('config.minPeakHeight should be a numeric value. Was: ' + String(config.minPeakHeight));
     }
 
@@ -104,7 +104,7 @@ Slayer.prototype = {
       return this;
     }
 
-    throw new TypeError('.use() expects its first and only paramter to be a peak detection function.')
+    throw new TypeError('.use() expects its first and only paramter to be a peak detection function.');
   },
   /**
    * Index accessor applied to each series item.

Diff for: lib/core.js

@@ -27,9 +27,9 @@ var commons = require('./_common.js');
 function fromArray(data){
   var self = this;
 
-  return new Promise(function(resolve, reject) {
+  return new Promise(function(resolve) {
     if (!Array.isArray(data)){
-      throw new TypeError('The data argument should be an array of time series values.')
+      throw new TypeError('The data argument should be an array of time series values.');
     }
 
     var spikes = data
@@ -39,7 +39,7 @@ function fromArray(data){
       .map(commons.objectMapper.bind(self, data))
       .filter(commons.cleanEmptyElement.bind(null, self.config.transformedValueProperty));
 
-      resolve(spikes);
+    resolve(spikes);
   });
 }
 

Diff for: lib/readers/array.js

@@ -61,11 +61,10 @@ function createReadStream(options){
   var emittedCache = [];
   var currentOffset = 0;
   var SLIDING_WINDOW_SIZE = this.config.minPeakDistance * options.bufferingFactor;
-  console.log(SLIDING_WINDOW_SIZE)
   var SLIDING_WINDOW_OVERLAP = SLIDING_WINDOW_SIZE * options.lookAheadFactor;
 
   var findSpikes = function findSpikes(items, stream) {
-    var spikes = items
+    return items
       .map(self.getValueY.bind(self))
       .map(self.filterDataItem.bind(self))
       .map(self.algorithm.bind(self, self.config.minPeakDistance))
@@ -74,7 +73,7 @@ function createReadStream(options){
       .map(incrementOffset.bind(self, 'x', currentOffset))
       .filter(cleanEmitted.bind(self, 'x', emittedCache))
       .map(pushToStream, stream);
-  }
+  };
 
   var flush = function flushBuffer(done) {
     findSpikes(buffer, this);

Diff for: lib/readers/stream.js

@@ -5,7 +5,8 @@
   "main": "index.js",
   "scripts": {
     "test": "nyc mocha --reporter dot 'test/**/*.js'",
-    "eslint": "eslint ./lib/",
+    "posttest": "npm run lint",
+    "lint": "eslint index.js ./lib",
     "benchmarks": "./bin/run-benchmarks.js"
   },
   "repository": {
@@ -35,7 +36,7 @@
   "devDependencies": {
     "benchmark": "^1.0.0",
     "chai": "^3.5.0",
-    "eslint": "^0.5.0",
+    "eslint": "^3.7.1",
     "mocha": "^3.1.0",
     "nyc": "^8.3.0",
     "sinon": "^1.9.1",