Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

Add 'bblfsh-cli' binaries to the release assets #115

Open
dpordomingo opened this issue Mar 6, 2019 · 4 comments
Open

Add 'bblfsh-cli' binaries to the release assets #115

dpordomingo opened this issue Mar 6, 2019 · 4 comments

Comments

@dpordomingo
Copy link
Member

dpordomingo commented Mar 6, 2019

Could you add bblfsh-cli binaries (for the considered platforms) to the released assets?
that way it could be directly wgeted ;)

@creachadair
Copy link
Contributor

Do you mean a binary build of the client itself? Right now we only have source tarballs for the client which are platform-independent. I think we'd have to choose a set of platforms to target. Or did you mean a subset of the source release?

@dpordomingo
Copy link
Member Author

I think it could be useful for some people if thebblfsh-cli binary could be downloaded from the release assets, ready to be used without compiling it from sources.

@creachadair
Copy link
Contributor

It makes sense, but if we're going to start pushing binary releases I think we should do it consistently for the various bblfsh projects. Unfortunately "the" binary isn't clearly defined, since it varies by platform (even in some cases across Linux versions). I'd be willing to update the issue to a more general "release binaries" request, though.

@dpordomingo dpordomingo changed the title Add 'bblfsh-cli' as a release asset Add 'bblfsh-cli' binaries to the release assets Mar 8, 2019
@dpordomingo
Copy link
Member Author

dpordomingo commented Mar 8, 2019

Oh, sorry, I realized that I described the problem as a user, only cared about his problem.
For sure, it should be considered different users from different platforms.

As an example, in Apps we deliver lookout-sdk for linux and darwin (example), and engine for linux, darwin, and windows (example), being the decision based on available time and prod necessities.

ps. I updated the issue desc in that direction, but feel free to edit it more accord to your preferences.

rporres pushed a commit to src-d/charts that referenced this issue Jun 28, 2019
Tests have been written in Python using bblfsh python client as we
don't have a bblfsh cli yet that we can download easily for these tests
(see bblfsh/go-client#115)

Signed-off-by: Rafael Porres Molina <[email protected]>
meyskens pushed a commit to src-d/charts that referenced this issue Jul 1, 2019
* added tests to bblfshd chart

Tests have been written in Python using bblfsh python client as we
don't have a bblfsh cli yet that we can download easily for these tests
(see bblfsh/go-client#115)

Signed-off-by: Rafael Porres Molina <[email protected]>

* bumped version

Signed-off-by: Rafael Porres Molina <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants