more fixes

Author: adelinn

.github/workflows/php-sast.yml

@@ -24,13 +24,51 @@ jobs:
     # - name: Validate composer.json and composer.lock
     #   run: composer validate --strict
 
+    # This config file gets auto-loaded by PHPStan
+    - name: Set PHPStan config
+      run: |
+        cat <<'EOF' > phpstan.neon
+        parameters:
+          level: 1 # form 0 to 11 where 0 is the loosest and 11 the strictest
+          errorFormat: github
+          paths:
+            - plugins/*
+          stubFiles:
+            - custom-defs.stub
+        includes:
+          - vendor/szepeviktor/phpstan-wordpress/extension.neon
+        EOF
+
+    - name: Create custom stubs for plugin functions. If this grows too big it can be commited as a separate file
+      run: |
+        cat <<'EOF' > custom-defs.stub
+        <?php
+
+        // Advanced Custom Fields stubs
+        if (!function_exists('get_field')) {
+            /**
+            * @param string $selector The field name or field key.
+            * @param mixed  $post_id Optional. Post ID, "option", false, or other ACF-supported context.
+            * @param bool   $format_value Optional. Whether to apply formatting logic. Default true.
+            * @param bool   $escape_html Optional. Whether to return escaped HTML.
+            *                            Requires $format_value to be true. Default false.
+            *
+            * @return mixed|null The field value.
+            */
+            function get_field(
+                string $selector,
+                $post_id = false,
+                bool $format_value = true,
+                bool $escape_html = false
+            );
+        }
+        EOF
+
     - name: Install PHPStan and Wordpress-stub
       run: |
         composer require --dev phpstan/phpstan
         composer require --dev szepeviktor/phpstan-wordpress
-        composer config --no-plugins allow-plugins.phpstan/extension-installer true
-        composer require --dev phpstan/extension-installer
 
     - name: Run PHPStan
-      run: vendor/bin/phpstan analyse plugins/* --error-format github --no-progress
+      run: vendor/bin/phpstan analyse --error-format github --no-progress
 

plugins/bcc-login/includes/class-bcc-login-visibility.php

@@ -487,7 +487,7 @@ function on_block_editor_assets() {
      * applies to category lists and REST API results.
      *
      * @param WP_Query $query
-     * @return WP_Query
+     * @return void
      */
     function filter_pre_get_posts( $query ) {
         // Don't filter posts for Phrase
@@ -628,7 +628,6 @@ function filter_pre_get_posts( $query ) {
 
         // Set the meta query to the complete, altered query
         $query->set('meta_query', $meta_query);
-        return;
     }
 
     /**
@@ -1159,7 +1158,7 @@ function render_visibility_meta_box_to_attachments( $post ) {
     /**
      * Save visibility value to attachments.
      */
-    function save_visibility_to_attachments( $attach_id ) {
+    function save_visibility_to_attachments( $attach_id, $post_after, $post_before ) {
         if ( !current_user_can( 'edit_post', $attach_id ) ) {
             return;
         }

plugins/bcc-login/includes/class-bcc-notifications.php

@@ -196,7 +196,7 @@ public function send_notification($post_id) {
 
                     $templates = array_key_exists($wp_lang, $this->settings->notification_templates)
                         ? $this->settings->notification_templates[$wp_lang]
-                        : (array_key_exists($site_language, $this->_settings->notification_templates)
+                        : (array_key_exists($site_language, $this->settings->notification_templates)
                             ? $this->settings->notification_templates[$site_language]
                             : null);
 

plugins/bcc-login/includes/class-bcc-storage.php

@@ -1,8 +1,6 @@
 <?php
 
 class BCC_Storage {
-    private BCC_Encryption $_encryption;
-
     private $_encryption_key;
     private $_encryption_method = "AES-256-CBC";
 

plugins/bcc-post-update-translations-notifier/includes/class-bcc-post-update-translations-notifier-updater.php

@@ -153,7 +153,7 @@ public function update( $transient ) {
 
 	}
 
-	public function purge(){
+	public function purge( $upgrader_object, $options ){
 
 		if (
 			$this->cache_allowed