Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are two Abbotsford "cities" that show up in the autocomplete results  #249

Closed
dawnbcgov opened this issue Sep 27, 2024 · 4 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dawnbcgov
Copy link
Contributor

dawnbcgov commented Sep 27, 2024

Describe the Bug

There are two Abbotsford "cities" that show up in the autocomplete results 

** Steps To Reproduce**
Steps to reproduce the behaviour:

  1. Go to https://organicsinfo.gov.bc.ca/map
  2. Type "abbotsford" in the search bar
  3. See error

Expected Behaviour

Only one shows up

Screenshots

image

Desktop (please complete the following information):

  • OS: [e.g. iOS] Windows 10 Enterprise
  • Browser [e.g. chrome, safari] Edge baby
  • Version [e.g. 22] 1.3.195.19
@dawnbcgov
Copy link
Contributor Author

@dawnbcgov
Copy link
Contributor Author

From convo with @mishraomp Potential 2 part approach:

1 - update places.js script to include place type (e.g., community, city, etc...) in the json: https://github.com/bcgov/nr-epd-organics-info/blob/main/frontend/public/places.json
2 - update the autocomplete behaviour (perhaps in https://github.com/bcgov/nr-epd-organics-info/blob/main/frontend/src/pages/map/search/AutocompleteItem.tsx)

@popkinj
Copy link
Collaborator

popkinj commented Jan 20, 2025

I would like to recommend a different approach by using the Provincial Geocoder as the official data source.

@popkinj popkinj moved this from In Progress to Ready to Test / Review in Organics Info Backlog (EPD Digital Services) Jan 27, 2025
@popkinj popkinj moved this from Ready to Test / Review to Done in Organics Info Backlog (EPD Digital Services) Jan 27, 2025
@dawnbcgov
Copy link
Contributor Author

Closed in #364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants