From 117175a9bb553a5c636ca9bdb0e874c769d7e673 Mon Sep 17 00:00:00 2001
From: joethorley <joe@poissonconsulting.ca>
Date: Fri, 10 Jan 2020 19:14:26 -0800
Subject: [PATCH] cran comments on fix

---
 cran-comments.md | 60 +++++++++++++++++++++++++++++++++++-------------
 1 file changed, 44 insertions(+), 16 deletions(-)

diff --git a/cran-comments.md b/cran-comments.md
index 7676289d..9eb1e267 100644
--- a/cran-comments.md
+++ b/cran-comments.md
@@ -8,7 +8,15 @@ release 3.6.1
 
 ## R CMD check results
 
-0 errors | 0 warnings | 1 note
+0 errors | 0 warnings | 2 notes
+
+Possibly mis-spelled words in DESCRIPTION:
+  Posthuma (7:3)
+  al (7:15)
+  et (7:12)
+  isbn (7:27)
+  
+The words are spelt correctly.
 
 Found the following (possibly) invalid URLs:
   URL: https://bcgov-env.shinyapps.io/ssdtools/
@@ -17,29 +25,49 @@ Found the following (possibly) invalid URLs:
     Status: Error
     Message: libcurl error code 35:
       	Unknown SSL protocol error in connection to bcgov-env.shinyapps.io:443
-
+      	
 The url is valid.
 
-Found the following (possibly) invalid file URIs:
-   URI: CONTRIBUTING.md
-     From: README.md
-   URI: CODE_OF_CONDUCT.md
-     From: README.md
+This is a resubmission.
+
+Thanks, we see on platforms without long doubles (noLD):
 
-Please use fully specified URLs or include the files in your package - or omit the links at all.
+ > test_check("ssdtools")
+ ── 1. Failure: fit_dists computable (@test-fit.R#101) ─────────────────────────
+ `ssd_fit_dists(data, dists = "gamma")` did not throw an error.
 
-I've replaced with fully specified URLs.
+ ── 2. Failure: fit_dists computable (@test-fit.R#107) ─────────────────────────
+ fit$sd not equal to c(scale = NaN, shape = 0.0414094229126189).
+ 2/2 mismatches (average diff: 0.00029)
+ [1] 7.51e+03 -    NaN ==     NaN
+ [2] 4.17e-02 - 0.0414 == 0.00029
 
-Is there some reference about the method you can add in the Description field in the form Authors (year) <doi:.....>?
+ ── 3. Failure: fit_dists computable (@test-fit.R#112) ─────────────────────────
+ fit$sd not equal to c(scale = 673.801371511101, shape = 0.0454275860604086).
+ 2/2 mismatches (average diff: 0.136)
+ [1] 673.5298 - 673.8014 == -2.72e-01
+ [2]   0.0454 -   0.0454 == -2.91e-06
 
-I've added the following text.
+ ── 4. Failure: fit pareto cis (@test-pareto.R#41) ─────────────────────────────
+ as.data.frame(ssd_hc(dist, ci = TRUE, nboot = 10)) not equal to structure(...).
+ Component "se": Mean relative difference: 2.947362e-08
 
-  Species sensitivity distributions are 
-  cumulative probability distributions which are fitted to 
-  toxicity concentrations for different species as described by
-  Posthuma et al. (2001) <isbn:9781566705783>.
+ ── 5. Failure: fit pareto cis (@test-pareto.R#52) ─────────────────────────────
+ as.data.frame(ssd_hp(dist, conc = 2, ci = TRUE, nboot = 10)) not equal to structure(...).
+ Component "est": Mean relative difference: 2.242121e-08
+ Component "se": Mean relative difference: 1.867354e-08
+ Component "lcl": Mean relative difference: 2.306981e-08
+ Component "ucl": Mean relative difference: 2.187393e-08
 
-Note I've used the 13 digit ISBN as there is no doi for the book.
+ ══ testthat results ═══════════════════════════════════════════════════════════
+ [ OK: 263 | SKIPPED: 0 | WARNINGS: 9 | FAILED: 5 ]
+ 1. Failure: fit_dists computable (@test-fit.R#101)
+ 2. Failure: fit_dists computable (@test-fit.R#107)
+ 3. Failure: fit_dists computable (@test-fit.R#112)
+ 4. Failure: fit pareto cis (@test-pareto.R#41)
+ 5. Failure: fit pareto cis (@test-pareto.R#52)
+ 
+ Fixed!
 
 ## Reverse dependencies