Skip to content

Latest commit

 

History

History
108 lines (86 loc) · 4.35 KB

CONTRIBUTING.md

File metadata and controls

108 lines (86 loc) · 4.35 KB
Raw

We always appreciate your contribution. ThorVG doesn't expect perfect patch contributions, instead we expect contributions if your patch makes thorvg better than before. This page guides the ThorVG contribution format.

Reviewers

Hermet Park (hermet) is the lead maintainer. Also there are designated maintainers you can request your pull-request for separate modules.

common: Junsu Choi (JSUYA)
sw_engine: Junsu Choi (JSUYA), Mira Grudzinska (mgrudzinska), Michal Szczecinski (mihashco)
gl_engine: Prudhvi Raj Vasireddi (prudhvirajv)
svg_loader: Junsu Choi (JSUYA), Mira Grudzinska (mgrudzinska), Michal Maciola (mmaciola)
jpg_loader: Michal Maciola (mmaciola)
tvg_loader: Michal Maciola (mmaciola)
tvg_saver: Mira Grudzinska (mgrudzinska)
wasm: Shinwoo Kim (kimcinoo)
svg2png: Junsu Choi (JSUYA), Michal Maciola (mmaciola)
capi: Michal Szczecinski (mihashco), Mira Grudzinska (mgrudzinska)

Self Test & Verification

After updating ThorVG code, please verify your change doesn't break the library. We suggest unit-tests using the Catch2 framework. You can easily run it with build commands as the following:

$meson . build -Dtests=true
$ninja -C build test

Please make it sure running all tests and no any fail case.

Expected Fail: 0
Fail: 0
Unexpected Pass: 0
Skipped: 0
Timeout: 0

Commit Message

[Module][Feature]: [Title]

[Description]

  • [Module] is a sub module majorly affected by your change. Most of times this indicates a sub folder name. This indicates whom need to review your patch as well. If your change don't belonged to any sub modules, you can replace with proper name or skip it. The name must be written in all lower alphabet characters.

    • ex) build / doc / infra / common / sw_engine / gl_engine / svg_loader / examples / wasm / svg2png ...

  • [Feature] is what major function/feature you changed. Normally this indicates a representive file name. You can keep the file name, but don't please contain any prefix(tvg) nor suffix(Impl) here.

    • ex) Canvas / TaskScehduler / SvgLoader / SvgBuilder / SwRle / GlRenderer / ...

  • [Title] is a brief description of your change. It must be described in one sentence.

    • ex) "Fixed a typo"
    • ex) "Fixed compile warnings"
    • ex) "Code refactoring"
    • ex) "Fixed a rendering bug that overlapped shapes inproper way."

  • [Description] There is no any strict formats, but it must describe what you did in this patch as far as possible you can describe in detail.

    If you fixed any bugs, it must contain below:

    • what type of bug
    • conditions to reproduce it
    • root cause
    • solution

    Or if you add a new feature or function, it must contain below:

    • what sort of features
    • api full specification (if any api additions)
    • any necessity
    • condition / restriction
    • reference or sample

    Lastly, please append any issue ticket numbers in this section if any.

  • Here is a overall commit message what we expect to review:

    • common composite: newly added path clipping feature

      We introduced new method Paint::composite() to support composite behaviors.
      This allows paints to composite with other paints instances.
      Composite behaviors depend on its composite method type.
      Here we firstly introduced "ClipPath" method to support clipping by path unit of paint.

      tagetPaint->composite(srcPaint, CompositeMethod::ClipPath);

      Beaware if the source paint doesn't contain any path info, clipping won't be applied as you expected.

      @API Additions:
      enum CompositeMethod {None = 0, ClipPath};
      Result Paint::composite(std::unique_ptr target, CompositeMethod method) const noexcept;

      @Examples: added ClipPath

      @References: any links to the references such as screenshot images.

      @Issues: 49


Pull Request

Once you submitted a pull request(PR), please make it sure below check list.

  • Reviewers: Check Reviewers List
  • Assignees: You
  • Labels: Patch Purpose
  • CODING STYLE CHECK: Must be perfect