New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java parser doesn't check for matching channel when parsing multi-part message #37

Open

bcl opened this issue Mar 6, 2021 · 0 comments

Owner

bcl commented Mar 6, 2021 •

edited

Loading

In the C code it checks for the message sequence, order, and channel number: https://github.com/bcl/aisparser/blob/master/c/src/vdm_parse.c#L458 but in the Java parser it accepts whatever the current channel is: https://github.com/bcl/aisparser/blob/master/java/src/main/java/com/aisparser/Vdm.java#L115

(I no longer have a java development setup so am unable to fix this).

This shouldn't be a problem as long as the parser is fed messages that are from the same channel, and in order.

bcl mentioned this issue

[Java] Messages without channel code not supported #2

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment