Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV add-ons: peak finding, plotting #16

Open
p2jones opened this issue Sep 6, 2019 · 3 comments
Open

CV add-ons: peak finding, plotting #16

p2jones opened this issue Sep 6, 2019 · 3 comments

Comments

@p2jones
Copy link
Contributor

p2jones commented Sep 6, 2019

In my fork, I've added functionality to cv.py:

  • get_peaks(): returns a DataFrame of peak positions and heights, and other info from scipy find_peaks. The function also finds a peak at the upper voltage limit. I'm not sure how to best solve this.
  • plot(): plots the CV, including peaks, arrows showing scan direction. It can convert units as well, and includes correct units in the axis labels.
@p2jones
Copy link
Contributor Author

p2jones commented Sep 6, 2019

I need to update get_peaks() to work also for all cycles in one go.

@bcliang
Copy link
Owner

bcliang commented Feb 11, 2021

Hi @p2jones this is a really old thread. However, I actually have a need for peak detection, and specifically tracking peaks (and peak amplitude) over cycles. Wondering if you ever finalized get_peaks

@p2jones
Copy link
Contributor Author

p2jones commented Feb 12, 2021

It worked well enough for me, and I could track peak positions and amplitudes over cycles. I just pushed some additional changes but those are related to plotting functions.
https://github.com/NMI-MSNT/gamry-parser/blob/master/gamry_parser/cv.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants