Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass bundle class to fhirpy client #132

Open
ruscoder opened this issue Oct 1, 2024 · 1 comment
Open

Pass bundle class to fhirpy client #132

ruscoder opened this issue Oct 1, 2024 · 1 comment

Comments

@ruscoder
Copy link
Member

ruscoder commented Oct 1, 2024

Since fhir-py-types Bundle class parses included resources, it will be good to return parsed resources in fetch/fetch_all/fetch_raw. It won't infer types but the returned resources will be models instead of AsyncFHIRResource

It also solves issue mentioned in #96 (comment)

@ruscoder
Copy link
Member Author

ruscoder commented Oct 1, 2024

The issue is only with client method like get() that return either ResourceType or dict if no ResourceType specified. For uniformity all methods shall return valid typed model.

We can forbid using client.get and other methods without explicit resource type but these methods are used by SearchSet/Resource classes..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant