Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common] pullSecret name should be configurable #117

Open
TobyTheHutt opened this issue Sep 29, 2023 · 1 comment
Open

[common] pullSecret name should be configurable #117

TobyTheHutt opened this issue Sep 29, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@TobyTheHutt
Copy link
Contributor

TobyTheHutt commented Sep 29, 2023

Is your feature request related to a problem? Please describe.
No.

Describe the solution you'd like
In the current state, the pullSecret can be turned on or off as a boolean . The name consists of the library.name variable and the suffix -registry-pull-secret, as described in the default values.yaml.

It's desirable in some use cases that the name of the secret can be set as a string.

Describe alternatives you've considered
If it's in one's power, they might change the naming concept of the K8s objects according to the common Chart. Alternatively, you might swallow the pill and rename/workaround the automatically generated secret with whatever mechanisms suit you best.

Additional context
-

@TobyTheHutt TobyTheHutt added the enhancement New feature or request label Sep 29, 2023
@TobyTheHutt TobyTheHutt self-assigned this Sep 29, 2023
@nschmid
Copy link

nschmid commented May 23, 2024

Hi @TobyTheHutt
I think that has already been added a while ago. See: https://github.com/bedag/helm-charts/blob/master/charts/common/values.yaml#L45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants