Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce MATLAB boilerplate #2

Open
beddalumia opened this issue Jan 12, 2022 · 2 comments
Open

Reduce MATLAB boilerplate #2

beddalumia opened this issue Jan 12, 2022 · 2 comments

Comments

@beddalumia
Copy link
Owner

beddalumia commented Jan 12, 2022 •
edited
Loading

We have a lot of boilerplate within matlab scripts and functions. We can indeed drastically reduce it by collecting all the elementary routines in suitable MATLAB packages, that will then become required dependencies for this repository.

Target repository for the new packages: https://github.com/bellomia/DMFT-LAB
beddalumia added a commit that referenced this issue Jan 12, 2022
@beddalumia
Reduce MATLAB boilerplate: PART I
6dee035 
We start here addressing issue #2

Twin commit: beddalumia/QcmP-LAB@c185df1
beddalumia added a commit that referenced this issue Jan 12, 2022
@beddalumia
Reduce MATLAB boilerplate: PART II
48b72c1 
More about #2

Twin commit: beddalumia/QcmP-LAB@00c06be
beddalumia added a commit that referenced this issue Jan 12, 2022
@beddalumia
Reduce MATLAB boilerplate: PART III
280cc8e 
Issue #2 touches MF scripts. (*)

Twin commit: beddalumia/QcmP-LAB@153e87a

--------
(*) This calls for some renaming, I'll think about it.
beddalumia added a commit that referenced this issue Jan 13, 2022
@beddalumia
Reduce MATLAB boilerplate: PART IV
72d9cdb 
Issue #2 touches the RunningDMFT and SLURM scripts  😄
> Triggers also a reshape of the KMH-DMFT_mat directory.

NB. RunningDMFT_refresh is still here cause the runDMFT.refresh_line() function is still work-in-progress.
__________
Ref. to beddalumia/QcmP-LAB@a88c1fe
beddalumia added a commit that referenced this issue Jan 13, 2022
@beddalumia
Reduce MATLAB boilerplate: PART V
c0a9410 
Issue #2 touches the MF-running scripts [+ polish on DMFT-SLURM scripts]

Some bugs have been fixed at beddalumia/QcmP-LAB@856ab5e and now we can say that every MF script runs smoothly (single-line, full-diagram, phase maps, energy surfaces!)

---------

We are ready to attack the nasty plotting scripts now (by extending the +plotDMFT package within DMFT-LAB) 🚀
@beddalumia
Copy link
Owner Author

Commit be9a12d adds DMFT-LAB to the requirements, and refers to it in several markdown files.

@beddalumia
Copy link
Owner Author

Commit bad4628 embeds DMFT-LAB as a git submodule.

beddalumia added a commit that referenced this issue Apr 26, 2022
@beddalumia
Reduce MATLAB boilerplate: PART VI
167fe80 
• Removing all 'spectral plotting' scripts, following development of the
  +plotDMFT module in DMFT-LAB
  > fast-forward of the relevant submodule

• Finally pruning RunningDMFT_refresh, for that runDMFT.refresh_line has
  been tested enough to supersede it.

—————————————————————————— Issue #2 - TODO —————————————————————————————

————> DMFT-LAB should soon extend the +plotDMFT module, allowing a deep
      refactor of both PlotDMFT and PlotMF scripts. At least making use
      of abstract functions for plotting observable lines, if not even
      implementing a totally generic interface for 2d-phase diagrams.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@beddalumia