Skip to content
This repository has been archived by the owner on May 31, 2020. It is now read-only.

Test suite fails for both python 3.5.3 and 3.4.4 #578

Open
alisianoi opened this issue Jun 21, 2017 · 1 comment
Open

Test suite fails for both python 3.5.3 and 3.4.4 #578

alisianoi opened this issue Jun 21, 2017 · 1 comment

Comments

@alisianoi
Copy link

Hello, my OS is Archlinux, which uses the latest-and-greatest versions of its packages.

Since batavia requires specific python and node versions, I use:

  1. pyenv and its pyenv-virtualenv plugin to install specific cpython versions and then manage the virtual environments.

  2. nvm to install and use specific versions of node

So, my pyenv is 1.0.10-64-g29436ff and my nvm is 0.33.2. I am using node version 6.11.0 and pythons of two versions for this report: 3.5.3 and 3.4.4. Results are below:

When running batavia's python setup.py test command:

  1. under the 3.5.3 virtual environment, I get 17 failed tests, here is the log.
  2. under the 3.4.4 virtual environment, I get 2 failed tests, here is the log

Any thoughts?

@freakboy3742
Copy link
Member

Ok - so there are a couple of different problems surfacing here.

The 3.4.4 failures are due to a timezone problem. There's something about how your box is determining your current system time that isn't coming out right. This is very difficult for us to diagnose, as it depends on your local timezone.

If you're able to step through time.mktime in batavia/modules/time.js to confirm which branches of the code are activating (or not activating), and what values are coming back from timezone guesses etc, that would be extremely helpful.

The extra failures in 3.5.3 are due to two causes:

  • A minor formatting difference in the way floating point numbers are being displayed, and
  • A minor change in the output format of certain error messages.

These sort of minor output changes are really common between Python versions (and even between micro versions). They're both relatively simple to fix - but unfortunately, we don't have the infrastructure in place to test both 3.4 and 3.5.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants