Skip to content

Date.toLocaleTimeString does not support option hour12 #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
saibing opened this issue Aug 28, 2024 · 1 comment
Closed

Date.toLocaleTimeString does not support option hour12 #344

saibing opened this issue Aug 28, 2024 · 1 comment

Comments

@saibing
Copy link

saibing commented Aug 28, 2024

quickjs version: 2024-01-13

~/git/c/quickjs-2024-01-13$ qjs
QuickJS - Type "\h" for help
qjs > console.log(new Date().toLocaleTimeString("en-US", { hour12: false }));
10:13:46 AM
undefined
qjs >

Expected output '10:13:46', actual output '10:13:46 AM'
zenHeart pushed a commit to zenHeart/quickjs that referenced this issue Mar 25, 2025
@chqrlie
Improve dump option support (bellard#344)
16e7661 
- DUMP_XXX defined as nothing or 0 produces unconditional output
- DUMP_XXX defined as a bitmask produces conditional output based
    on command line option -d<bitmask>
- add `JS_SetDumpFlags()` to select active dump options
- accept -d[<hex mask>] and --dump[=<hex mask>] to specify active
    dump options, generalize command line option handling
- improve DUMP_READ_OBJECT output, fix indentation issue
@bellard
Copy link
Owner

bellard commented Mar 27, 2025

quickjs does not support the internationalization standard, so it works as designed.

@bellard bellard closed this as completed Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saibing @bellard