-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to BemCell.create and BemEntityName.create #113
Comments
We should not use .create here ;-) |
Ok, i understand that .create can't guarantee correct interpretation, but is current constructor ok? Is it convenient to pass every time as const ob = {};
ob.block = entity.modName;
if (entity.modName) {
ob.mod = {};
ob.mod.name = entity.modName;
ob.mod.val = entity.modVal;
}
const lala = new BemEntityName({ entity: ob, tech: entity.tech }); or smth like that? |
new BemCell({
entity: new BemEntityName({
block: entity.block,
elem: entity.elem,
mod: entity.modName
? { name: entity.modName, val: enrity.modVal }
: undefuned
}),
tech: entity.tech
}) Like that? |
looks ugly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now we have deprecation messages when we use a constructor for BemCell and provide to it
modName
andmodVal
fieldsThe text was updated successfully, but these errors were encountered: