Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Stats Collector by better handling the stop of the collection #11

Closed
VincenzoFerme opened this issue Oct 16, 2015 · 2 comments
Closed

Improve Stats Collector by better handling the stop of the collection #11

VincenzoFerme opened this issue Oct 16, 2015 · 2 comments
Assignees
@Cerfoglg
Labels
enhancement
Milestone
Priorities

Comments

@VincenzoFerme
Copy link
Member

Remove the shared variable "collecting" that handles the stop of the collection, and try to see if it possible to directly use the API to understand when there are no more data.

Useful reference: http://adampresley.com/2015/02/16/waiting-for-goroutines-to-finish-running-before-exiting.html
@VincenzoFerme VincenzoFerme self-assigned this Oct 16, 2015
@VincenzoFerme VincenzoFerme added this to the 0.0.1 milestone Oct 16, 2015
@Cerfoglg Cerfoglg mentioned this issue Nov 20, 2015
Merged
@Cerfoglg
Copy link
Contributor

This can also be closed now, since issue #23 is what's left for the collection stopping

@VincenzoFerme
Copy link
Member Author

Closed by #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cerfoglg Cerfoglg

Labels
enhancement
Milestone
Priorities
Development

No branches or pull requests
2 participants
@VincenzoFerme @Cerfoglg