Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the implemented collectors clean and remove hard coded stuff #13

Open
VincenzoFerme opened this issue Oct 16, 2015 · 0 comments
Open
Assignees
Milestone

Comments

@VincenzoFerme
Copy link
Member

Remove:

  • Hard coded environment variables
  • Hard coded strings
  • Not needed folders and files

Add:

  • Dependency on envconsul to retrieve the environment variables
  • Consul service discovery

Manage:
- Dependency by only using Godeps

Docker:

  • Container go that builds a project from git and remove the dependency on golang;
  • Also have Dockerfile for local development, using base container to avoid code cloning among Dockerfile, if possible

Comments:

  • @Cerfoglg add some explicative comment to the code, after refactoring it.
@VincenzoFerme VincenzoFerme self-assigned this Oct 16, 2015
@VincenzoFerme VincenzoFerme added this to the 0.0.1 milestone Oct 16, 2015
@VincenzoFerme VincenzoFerme modified the milestones: Sooner or Later, 0.0.1 Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants