Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit Validation of Collection-Type Models #56

Open
benmccallum opened this issue Jul 24, 2021 · 1 comment
Open

Implicit Validation of Collection-Type Models #56

benmccallum opened this issue Jul 24, 2021 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@benmccallum
Copy link
Owner

benmccallum commented Jul 24, 2021

Got a report from Oisín Grehan and Nacer Dergal in Slack of a scenario where they weren't seeing the validator run.

Turns out they had an array arg where the inner type had the validator. e.g. [SomeInput]

Essentially this is "Implicit Validation of Collection-Type Models" as discussed in FluentValidation's docs here.

By default they don't handle it, but you can opt-in to handle it.

Context:
Slack thread

@benmccallum
Copy link
Owner Author

benmccallum commented Sep 29, 2021

This overlaps a little bit with discussions on #61 with Jeremy and implicitness opening a can of worms.

Plan is just to document that explicitness is key.

  • Update readme

If anyone disagrees and would like to see this feature, let me know in the comments.

@benmccallum benmccallum self-assigned this Sep 29, 2021
@benmccallum benmccallum added the documentation Improvements or additions to documentation label Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant