-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repository is large (200MB) #10
Comments
I've no argument against rewriting Git history, but I'm not proficient at all in this exercice ! The weight of the module is indeed coming from test font files. I would prefer not to reduce test coverage, but if they can be extracted in a test-only dependency, let's do it. What would be the way to proceed ? Do go modules have a way to specify test-only deps ? |
Thanks. I'll take a stab at it if no-one else beats me to it.
Not that I know of, but I'm hoping that non-test builds can avoid downloading the test-module. |
PR #12 changes the tests to use an external module for their data. For the git history rewrite, I came up with:
from https://www.deployhq.com/git/faqs/removing-large-files-from-git-history. Note that only BRANCH is rewritten, which is intended; you want to keep your existing tags pointing at the old data. I believe |
Although most likely unrelated, it might be worth mentioning that the size of the downloaded zip differs by ca 80MB across three different computers right now. Needless to say, there are issues on the machine that only receives 53 MB instead of 130MB Although a github problem I assume, it might be solved by slimming the repo. |
PR #12 has indeed nicely slimmed down the repo. |
Did you run However, the reason I suggested a branch instead of In summary, I suggest running |
The v0.1.1 release is much smaller because the module no longer contains test data. See benoitkugler/textlayout#10 Signed-off-by: Elias Naur <[email protected]>
The repository seems to now only be 17MB. I think this can be closed |
I couldn't help notice that downloading
github.com/benoitkugler/textlayout
takes quite a while, so I ranto check.
It's unfortunate to have to fetch at least ~200 MB data, or even > 300 MB for the entire history just to access the Go source. Would you be open to slimming down the repository and rewrite Git history to obtain a leaner dependency? If it's inconvenient to slim down the testdata files, perhaps they could be extracted into a separate (test-only) dependency module?
The text was updated successfully, but these errors were encountered: