Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent API regarding table update #15

Open
SamJoan opened this issue Feb 22, 2020 · 0 comments
Open

Inconsistent API regarding table update #15

SamJoan opened this issue Feb 22, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@SamJoan
Copy link
Member

SamJoan commented Feb 22, 2020

On table.py, on the EndpointTableModel class, the add() method does not refresh the table because of the issues I previously had with fireTableDataInserted after a clear() call when the table was sorted, where the insertion would happen at an offset which would trigger a KeyError in getEndpoint. See #9.

Now, clear(), update() and setFuzzed() all trigger the update of the table, but not add(). I think that all methods should be updated in such a way that they don't trigger the update for consistency, and we should make that the responsibility of the caller.

@SamJoan SamJoan added the enhancement New feature or request label Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant