Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fuzzExecutorService from ui.py to fuzz.py inside FuzzRunner. #28

Open
SamJoan opened this issue Mar 25, 2020 · 1 comment
Open

Move fuzzExecutorService from ui.py to fuzz.py inside FuzzRunner. #28

SamJoan opened this issue Mar 25, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@SamJoan
Copy link
Member

SamJoan commented Mar 25, 2020

The issue is here.

https://github.com/benteveo-kiwi/benteveo-toolbox/blob/master/fuzz.py#L156

Maybe we should avoid refering to the state object altogether, and initialise the executor within run. In that case we need to make sure we call shutdown() there. https://blog.fastthread.io/2015/10/23/memory-leak-in-java-executor-2/
@SamJoan
Copy link
Member Author

SamJoan commented Mar 27, 2020

Actually, I made this change and it causes the fuzzer to hang. :( So, two different executors are required due to the architecture of the code.

@SamJoan SamJoan added this to the v0.2.2 milestone Apr 4, 2020
@SamJoan SamJoan added the bug Something isn't working label Apr 4, 2020
@SamJoan SamJoan changed the title fuzz.py refers to executorService instead of fuzzExecutorService Move fuzzExecutorService from ui.py to fuzz.py inside FuzzRunner. Jun 26, 2020
@SamJoan SamJoan removed this from the v0.2.2 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SamJoan