Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resize bug regular videos #66

Open
mamaretti opened this issue May 8, 2017 · 2 comments
Open

resize bug regular videos #66

mamaretti opened this issue May 8, 2017 · 2 comments

Comments

@mamaretti
Copy link

Hi rochestb, thx for the nice script.
there is an issue when using it with
fitToBackground: false

you can see it when you resize the browser window.
http://rochestb.github.io/jQuery.YoutubeBackground/

i changed (LINE 223)
if (!self.options.fitToBackground) {
container = self.$node;
}

to
if (!self.options.fitToBackground) {
container = self.$node;
return;
}

to avoid resizing

@lyjen
Copy link

lyjen commented Feb 5, 2020

Hi @rochestb , any chance we can display the same for both fitToBackground: true and false when resizing? It's good if we can get middle part of the video in fitToBackground:True and better to apply the same to fitToBackground:False. Currently, when using container, it displays the left part of the video. It would be great if you add something to make it the same as fitToBakcground:true.

Sample:
fitToBackground: true,
nut

fitToBackground: false,
nut2

Many thanks,

@bento-n-box
Copy link
Owner

Does someone want to open a PR for this? I don't really maintain this plugin anymore but can help get it on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants