From 88bf4ae9536381cc30f2975864f9203a46651c06 Mon Sep 17 00:00:00 2001
From: Sanjeev Lakhwani <lakhwani.sanjeev691@gmail.com>
Date: Thu, 29 Aug 2024 12:14:32 -0400
Subject: [PATCH 1/2] feat(charts): Added a chartclick event to BaseBarChart

---
 src/Components/Charts/BaseBarChart.tsx | 3 ++-
 src/types/chartTypes.ts                | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/Components/Charts/BaseBarChart.tsx b/src/Components/Charts/BaseBarChart.tsx
index f0d8bfa..efcf423 100644
--- a/src/Components/Charts/BaseBarChart.tsx
+++ b/src/Components/Charts/BaseBarChart.tsx
@@ -44,6 +44,7 @@ const BaseBarChart: React.FC<BaseBarChartProps> = ({
   units,
   title,
   onClick,
+  onChartClick,
   chartFill,
   otherFill,
   ...params
@@ -78,7 +79,7 @@ const BaseBarChart: React.FC<BaseBarChartProps> = ({
     <ChartWrapper responsive={typeof width !== 'number'}>
       <div style={TITLE_STYLE}>{title}</div>
       <ResponsiveContainer width={width ?? '100%'} height={height}>
-        <BarChart data={data} margin={BAR_CHART_MARGINS}>
+        <BarChart data={data} margin={BAR_CHART_MARGINS} onClick={onChartClick}>
           <XAxis
             dataKey="x"
             height={20}
diff --git a/src/types/chartTypes.ts b/src/types/chartTypes.ts
index 17fbf82..469d4ca 100644
--- a/src/types/chartTypes.ts
+++ b/src/types/chartTypes.ts
@@ -1,4 +1,5 @@
 import type { PieProps, BarProps } from 'recharts';
+import type { BarChartProps as RechartsBarChartProps } from 'recharts/index.d.ts';
 import { COUNT_KEY, OTHER_KEY } from '../constants/chartConstants';
 
 export type CategoricalChartDataType = CategoricalChartDataItem[];
@@ -83,6 +84,7 @@ export interface BaseBarChartProps extends BaseCategoricalChartProps {
   title?: string;
   units: string;
   onClick?: BarProps['onClick'];
+  onChartClick?: RechartsBarChartProps['onClick'];
 }
 
 export interface BarChartProps extends Omit<BaseBarChartProps, 'chartFill' | 'otherFill'> {

From a68834f155c450529fe7e62ba13076d846b854b7 Mon Sep 17 00:00:00 2001
From: Sanjeev Lakhwani <lakhwani.sanjeev691@gmail.com>
Date: Thu, 29 Aug 2024 12:27:33 -0400
Subject: [PATCH 2/2] test(charts): Added clickHandler logging to test barchart
 + histogram

---
 test/js/TestBarChart.tsx  | 12 ++++++++++++
 test/js/TestHistogram.tsx | 12 ++++++++++++
 2 files changed, 24 insertions(+)

diff --git a/test/js/TestBarChart.tsx b/test/js/TestBarChart.tsx
index ea09578..d6291ab 100644
--- a/test/js/TestBarChart.tsx
+++ b/test/js/TestBarChart.tsx
@@ -26,6 +26,12 @@ const TestBarChart: React.FC = () => {
           height={sizeStateFixed.height}
           width={sizeStateFixed.width}
           colorTheme="new"
+          onClick={(f) => {
+            console.log('onClick', f);
+          }}
+          onChartClick={(f) => {
+            console.log('onChartClick', f);
+          }}
         />
       </ResizableCard>
       <ResizableCard title="Responsive Bar Chart" sizeState={sizeStateResponsive} onSizeChange={setSizeStateResponsive}>
@@ -40,6 +46,12 @@ const TestBarChart: React.FC = () => {
           units="management units"
           height={sizeStateResponsive.height}
           colorTheme="new"
+          onClick={(f) => {
+            console.log('onClick', f);
+          }}
+          onChartClick={(f) => {
+            console.log('onChartClick', f);
+          }}
         />
       </ResizableCard>
     </Space>
diff --git a/test/js/TestHistogram.tsx b/test/js/TestHistogram.tsx
index 886c877..7d53088 100644
--- a/test/js/TestHistogram.tsx
+++ b/test/js/TestHistogram.tsx
@@ -25,6 +25,12 @@ const TestBarChart: React.FC = () => {
           units="management units"
           height={sizeStateFixed.height}
           width={sizeStateFixed.width}
+          onClick={(f) => {
+            console.log('onClick', f);
+          }}
+          onChartClick={(f) => {
+            console.log('onChartClick', f);
+          }}
         />
       </ResizableCard>
       <ResizableCard title="Responsive Histogram" sizeState={sizeStateResponsive} onSizeChange={setSizeStateResponsive}>
@@ -43,6 +49,12 @@ const TestBarChart: React.FC = () => {
           ]}
           units="management units"
           height={sizeStateResponsive.height}
+          onClick={(f) => {
+            console.log('onClick', f);
+          }}
+          onChartClick={(f) => {
+            console.log('onChartClick', f);
+          }}
         />
       </ResizableCard>
     </Space>