Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom helm command line options #34

Open
tjcrone opened this issue Nov 29, 2019 · 5 comments
Open

Add support for custom helm command line options #34

tjcrone opened this issue Nov 29, 2019 · 5 comments

Comments

@tjcrone
Copy link
Contributor

tjcrone commented Nov 29, 2019

Sometimes I need to include --force because of a failed deployment on the first deployment, or include the --timeout option to helm. When I need to do that I hardcode these, and use my version of hubploy. I'm wondering if we could include an option for custom helm options instead? @yuvipanda, I'm happy to make these changes and PR if you suggest a preferred way of doing this. Thanks!

@yuvipanda
Copy link
Collaborator

@tjcrone yeah, I think a '--helm-options' flag maybe? That could just get passed in to helm.

@tjcrone
Copy link
Contributor Author

tjcrone commented Nov 29, 2019

Okay. I'm going to have to think about how to pass a list of flags and values for another program through the hubploy argparse with a --helm-options flag. Maybe a list of strings. Maybe a dict. I have not passed a set of options for another program to argparse before. If you have a preferred method, please let me know.

@tjcrone
Copy link
Contributor Author

tjcrone commented Nov 29, 2019

Kindof need a way to get **kwargs working with argparse and the CLI. Googling ...

@yuvipanda
Copy link
Collaborator

I'd suggest taking it in as a single string, splitting it with shlex.split, and then passing it to helm.

@tjcrone
Copy link
Contributor Author

tjcrone commented Nov 29, 2019

Another option would be to add "--force=False" and "--timeout=300" as separate argparse options to hubploy, and then pass them on to helm. I kindof like this idea better. What do you think? If you do not like this, I will do it as a string like you suggest.

@consideRatio consideRatio changed the title Add support for custom helm options Add support for custom helm command line options Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants