From 2aa5625756fd26610d0dc6f752ee39828105c294 Mon Sep 17 00:00:00 2001 From: Kevin Chen Date: Mon, 5 Jan 2026 22:03:10 -0500 Subject: [PATCH 1/2] fix: warning should only fire once --- crates/bevy_pbr/src/render/gpu_preprocess.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/bevy_pbr/src/render/gpu_preprocess.rs b/crates/bevy_pbr/src/render/gpu_preprocess.rs index ed3040c52cb11..b88ee7393ca27 100644 --- a/crates/bevy_pbr/src/render/gpu_preprocess.rs +++ b/crates/bevy_pbr/src/render/gpu_preprocess.rs @@ -52,7 +52,7 @@ use bevy_render::{ Render, RenderApp, RenderSystems, }; use bevy_shader::Shader; -use bevy_utils::{default, TypeIdMap}; +use bevy_utils::{default, once, TypeIdMap}; use bitflags::bitflags; use smallvec::{smallvec, SmallVec}; use tracing::warn; @@ -838,7 +838,7 @@ impl Node for LateGpuPreprocessNode { // Fetch the pipeline. let Some(preprocess_pipeline_id) = maybe_pipeline_id else { - warn!("The build mesh uniforms pipeline wasn't ready"); + once!(warn!("The build mesh uniforms pipeline wasn't ready")); return Ok(()); }; From 7ee35c2dd1704dbaf1d1e9c1b9638ef93485dad6 Mon Sep 17 00:00:00 2001 From: Kevin Chen Date: Tue, 6 Jan 2026 02:03:06 -0500 Subject: [PATCH 2/2] fix: use warn_once! instead --- crates/bevy_pbr/Cargo.toml | 1 + crates/bevy_pbr/src/render/gpu_preprocess.rs | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/crates/bevy_pbr/Cargo.toml b/crates/bevy_pbr/Cargo.toml index 6e9efc0faf49b..22aa4b724723a 100644 --- a/crates/bevy_pbr/Cargo.toml +++ b/crates/bevy_pbr/Cargo.toml @@ -42,6 +42,7 @@ bevy_derive = { path = "../bevy_derive", version = "0.18.0-dev" } bevy_diagnostic = { path = "../bevy_diagnostic", version = "0.18.0-dev" } bevy_ecs = { path = "../bevy_ecs", version = "0.18.0-dev" } bevy_light = { path = "../bevy_light", version = "0.18.0-dev" } +bevy_log = { path = "../bevy_log", version = "0.18.0-dev" } bevy_image = { path = "../bevy_image", version = "0.18.0-dev" } bevy_mesh = { path = "../bevy_mesh", version = "0.18.0-dev", features = [ "morph", diff --git a/crates/bevy_pbr/src/render/gpu_preprocess.rs b/crates/bevy_pbr/src/render/gpu_preprocess.rs index b88ee7393ca27..88b3bb3a08788 100644 --- a/crates/bevy_pbr/src/render/gpu_preprocess.rs +++ b/crates/bevy_pbr/src/render/gpu_preprocess.rs @@ -26,6 +26,7 @@ use bevy_ecs::{ system::{lifetimeless::Read, Commands, Query, Res, ResMut}, world::{FromWorld, World}, }; +use bevy_log::warn_once; use bevy_render::{ batching::gpu_preprocessing::{ BatchedInstanceBuffers, GpuOcclusionCullingWorkItemBuffers, GpuPreprocessingMode, @@ -52,7 +53,7 @@ use bevy_render::{ Render, RenderApp, RenderSystems, }; use bevy_shader::Shader; -use bevy_utils::{default, once, TypeIdMap}; +use bevy_utils::{default, TypeIdMap}; use bitflags::bitflags; use smallvec::{smallvec, SmallVec}; use tracing::warn; @@ -838,7 +839,7 @@ impl Node for LateGpuPreprocessNode { // Fetch the pipeline. let Some(preprocess_pipeline_id) = maybe_pipeline_id else { - once!(warn!("The build mesh uniforms pipeline wasn't ready")); + warn_once!("The build mesh uniforms pipeline wasn't ready"); return Ok(()); };