Skip to content
This repository has been archived by the owner on Nov 2, 2019. It is now read-only.

Inclusion in imgui's example #1

Open
ocornut opened this issue Jul 8, 2015 · 1 comment
Open

Inclusion in imgui's example #1

ocornut opened this issue Jul 8, 2015 · 1 comment

Comments

@ocornut
Copy link

ocornut commented Jul 8, 2015

Hello,

I'd like to include your example in the imgui/examples/ is that's ok.
Would you mind if it went there under the MIT license used in ImGui, as opposed to public domain?
Not a big difference but it'll just be simpler if all the code is using the same license.

Thanks,
Omar

@ocornut
Copy link
Author

ocornut commented Jul 8, 2015

I have included it now
https://github.com/ocornut/imgui/tree/master/examples/allegro5_example

It still says "public domain" which ideally I would like to remove with your permission to have a same license across all files.

ocornut/imgui@19e3c15
ocornut/imgui@489e28e
ocornut/imgui@c58d61d
ocornut/imgui@8db229b
ocornut/imgui@4d2d0ce
ocornut/imgui@bbaaab7
ocornut/imgui@2f574ef (anti-aliased branch)

What I have done:

  • Fixed keyboard modifiers.
  • Fixed rogue key 0 press.
  • Fixed mouse buttons.
  • Fixed clipping.
  • Fixed uv coordinates when using a non-default texture (using a custom vertex declaration, unfortunately Allegro doesn't have 32-bits colors support for vertices which is a weird overlooked thing, so we still have to convert the vertices).
  • Fixed handling of software mouse cursor + using Allegro system mouse cursor for the hardware one (Allegro is actually the first library I see that has all the mouse cursors by default).
  • Added a window title.
  • Added PageUp / PageDown keys.
  • Fixed the syntax and formatting and comments to exactly match the other examples.

I wanted to post there but for some reason the thread is locked:
https://www.allegro.cc/forums/thread/615234/1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant