Question about vendor js

[bogdanpetrea]

Hi,

I've been inspecting the vendor files from the static directory, and I found that react-modal.min.js has a few differences from the minified version found at https://registry.npmjs.org/react-modal/-/react-modal-3.15.1.tgz (as mentioned in package-lock.json).

react-dom and react seemed to match with their online versions, just not react-modal.

Any clue as to why and can it fixed?

[bhch]

The Django package includes an older version (v3.14.3) of react-modal.

When I release a new version of django-jsonform, I have to manually copy/paste the JS files from the development repository (react-json-form). I must have forgot update the react-modal lib.

[bogdanpetrea]

Thanks! I compared to 3.14.3 (and a few other versions) before posting here, and they still didn't match.

[bhch]

I'm seeing no differences: https://www.diffchecker.com/T7J33xLu

Could you check again?

[bogdanpetrea]

Hmm you're right.
I think what happened is I checked locally with git diff and pasting the online version added a newline or something like that. Might be my editor automatically adding a newline after a set number of characters, or I don't know.

Even after I pasted from npm in diffchecker I got a weird newline https://www.diffchecker.com/7MNzHUCv/ , but pasting from cloudflare shows no difference there indeed.

I didn't look closer for the other versions at what the differences were, as initially for 3.15.1 they were obvious...

So my bad in the end, sorry for wasting your time.