test: validate BIDS schema against metaschema with check-jsonschema

Author: candleindark

tools/schemacode/pyproject.toml

@@ -37,6 +37,7 @@ render = [
 ]
 tests = [
     "bidsschematools[expressions,render]",
+    "check-jsonschema",
     "codecov",
     "coverage[toml]",
     "flake8",

tools/schemacode/src/bidsschematools/tests/test_schema.py

@@ -1,7 +1,10 @@
 """Tests for the bidsschematools package."""
 
+import json
 import os
+import subprocess
 from collections.abc import Mapping
+from importlib.resources import files
 
 import pytest
 from jsonschema.exceptions import ValidationError
@@ -365,6 +368,38 @@ def test_valid_schema():
     schema.validate_schema(namespace)
 
 
+@pytest.mark.parametrize("regex_variant", ["default", "nonunicode", "python"])
+def test_valid_schema_with_check_json_schema(tmp_path, regex_variant):
+    """
+    Test that the BIDS schema is valid against the metaschema when validation is done
+    using the `check-jsonschema` CLI
+    """
+    bids_schema = schema.load_schema().to_dict()
+    metaschema_path = str(files("bidsschematools.data").joinpath("metaschema.json"))
+
+    # Save BIDS schema to a temporary file
+    bids_schema_path = tmp_path / "bids_schema.json"
+    bids_schema_path.write_text(json.dumps(bids_schema))
+
+    # Invoke the check-jsonschema to validate the BIDS schema
+    try:
+        subprocess.run(
+            [
+                "check-jsonschema",
+                "--regex-variant",
+                regex_variant,
+                "--schemafile",
+                metaschema_path,
+                str(bids_schema_path),
+            ],
+            capture_output=True,
+            text=True,
+            check=True,
+        )
+    except subprocess.CalledProcessError as e:
+        pytest.fail(f"check-jsonschema failed with code {e.returncode}: {e.stderr}")
+
+
 def test_add_legal_field():
     """Test that adding a legal field does not raise an error."""
     namespace = schema.load_schema()