-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] clarify/re-consider use of "n/a" in numeric columns #1938
Comments
Yes, |
- It somewhat addresses concern/discussion in bids-standard#1938
I think tools have adapted to n/a in all columns and such a change would trigger a lot of changes. |
Cool, let's then plan #1940 to fix this issue with just minute tune up to "wording". |
- It somewhat addresses concern/discussion in bids-standard#1938
Describe your problem in detail.
ATM specification for Tabular files https://bids-specification.readthedocs.io/en/stable/common-principles.html#tabular-files states
So, in the best reading of it, it mandates use of explicit
n/a
for a missing value in any (not only "String values" column) column.As
n/a
is not a standard placeholder, that unnecessarily complicates loading of such files using anything which expects numeric values for the column (e.g.onset
).Describe what you expected.
I have not investigated this further yet and do not have any specific recommendation ATM (e.g. after looking how pandas would expect to have float.nan to be defined in tsv etc). Just raising a possible discussion point.
At least we might want to reorder sentences to remove possible misassociation with string only columns, i.e. to have it
BIDS specification section
https://bids-specification.readthedocs.io/en/latest/...
The text was updated successfully, but these errors were encountered: