[ENH] Add interpretation of "n/a" onsets in events.tsv files #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1966 +/- ##
=======================================
Coverage 86.87% 86.87%
=======================================
Files 16 16
Lines 1410 1410
=======================================
Hits 1225 1225
Misses 185 185 ☔ View full report in Codecov by Sentry. |
effigies
reviewed
Oct 21, 2024
src/schema/objects/columns.yaml
Outdated
| @@ -339,7 +339,7 @@ onset: | |||
| Onset (in seconds) of the event, measured from the beginning of the acquisition | |||
| of the first data point stored in the corresponding task data file. | |||
| Negative onsets are allowed, to account for events that occur prior to the first | |||
| stored data point. | |||
| stored data point. A `n/a` value indicates the onset time is unknown or unavailable. | |||
There was a problem hiding this comment.
I would move this to the bottom to avoid breaking up discussion of negatives. And maybe "A value of n/a..." to get around the a/an weirdness with consonants like n (I would use "an n/a").
There was a problem hiding this comment.
moved actually at the end of the whole section
There was a problem hiding this comment.
Thanks for addressing this. I think n/a is fine. The description for onset now seems to be parallel to the description for duration.
effigies
approved these changes
Oct 21, 2024
effigies
changed the title
yarikoptic
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onsetcolumn ofevents.tsv#1943