Skip to content

Commit 3bd1153

Browse files
committed
minor fix units metadata; appeared twice in json
1 parent 2ea96c3 commit 3bd1153

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

eye2bids/_base.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,6 @@ class BasePhysioJson(dict[str, Any]):
110110
has_calibration: bool
111111

112112
def __init__(self, manufacturer: str, metadata: dict[str, Any] | None = None) -> None:
113-
self.update_from_metadata(metadata)
114-
115113
self["Manufacturer"] = manufacturer
116114
self["PhysioType"] = "eyetrack"
117115

@@ -126,7 +124,7 @@ def __init__(self, manufacturer: str, metadata: dict[str, Any] | None = None) ->
126124
"Origin": ("System startup"),
127125
}
128126

129-
units = self["Units"]
127+
units = metadata.get("Units") if metadata else None
130128

131129
self["x_coordinate"] = {
132130
"LongName": ("Gaze position (x)"),
@@ -155,12 +153,13 @@ def __init__(self, manufacturer: str, metadata: dict[str, Any] | None = None) ->
155153
"Units": "a.u.",
156154
}
157155

156+
self.update_from_metadata(metadata)
157+
158158
def update_from_metadata(self, metadata: None | dict[str, Any] = None) -> None:
159159
"""Update content of json side car based on metadata."""
160160
if metadata is None:
161161
return None
162162

163-
self["Units"] = metadata.get("Units")
164163
self["SoftwareVersion"] = metadata.get("SoftwareVersion")
165164
self["EyeCameraSettings"] = metadata.get("EyeCameraSettings")
166165
self["EyeTrackerDistance"] = metadata.get("EyeTrackerDistance")

0 commit comments

Comments
 (0)