Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[BUG] Legal Menu and Social Links are not aligned #165

Open
TheE opened this issue Jun 29, 2019 · 2 comments
Open

[BUG] Legal Menu and Social Links are not aligned #165

TheE opened this issue Jun 29, 2019 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@TheE
Copy link

TheE commented Jun 29, 2019

Describe the bug

The alignment of the footer's legal menu and the social icons is completely of. Additionally, the top border of the footer menu is not properly aligned with the content (the last child is missing the rest of the right margin):

benenson-footer-alignment

This seems to be caused by calling @include flexy-column(10) on the page-footerBottomHalf elements.

This is especially troublesome because it cannot be easily overwritten in a child theme.

To Reproduce
Steps to reproduce the behaviour:

  1. Add a menu to the Footer Legal location.
  2. Add some social links in the Customizer.
  3. Scroll to the site's footer.

Expected behaviour
The legal menu and the social' icons should be placed on the same hight, i.e. by simply using justify-content: space-between. The border of the footer menu should be properly aligned with the content.

Platform (please complete the following information):

  • OS: macOS
  • Browser: Safari
  • Version: 12.1.1
@TheE TheE added the bug Something isn't working label Jun 29, 2019
@TheE TheE changed the title [BUG] [BUG] Legal Menu and Social Links are not aligned Jun 29, 2019
@TheE
Copy link
Author

TheE commented Jul 1, 2019

I just realised that the misalignment of the border is an issue with the footer menu: the last child is missing the reset of its right margin.

@jaymcp jaymcp self-assigned this Jul 3, 2019
@jaymcp jaymcp added this to the v1.1.1 milestone Jul 3, 2019
@jaymcp
Copy link
Member

jaymcp commented Jul 3, 2019

Thanks for the report, @TheE; I'll make sure a fix for this gets into the next release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants