Variable state segments

[PaulTondeur]

Some segments of the state might be dynamic. Say the current locale for example.

Validating such state could be handled in a stateValidationResponder. Alternatively it might be an idea to introduce variable state segments.{locale}/home for example. These variables could be entered when needed. For example:

var home = new navigatorjs.NavigationState("{locale}/home")

var currentState = new navigatorjs.NavigationState("en_EN/home")

expect(currentState.equals(home, {locale:'en_EN'})).toBe(true)
expect(currentState.equals(home, {locale:'nl_NL'})).not.toBe(true)

Would this be a good idea?

[evannieuwburg]

Sounds like a swell idea.
+1

[PaulTondeur]

After rethinking this a bit more I came up with an argument not to implement such thing, as the following test would fail:

var home = new navigatorjs.NavigationState("{locale}/home")

navigator.data = {locale:"nl_NL"};
navigator.request(home);
expect(currentState.equals(home, {locale:'nl_NL'})).toBe(true);

navigator.data = {locale:"en_EN"};
navigator.request(home);
expect(currentState.equals(home, {locale:'en_EN'})).toBe(true);

history.go(-1);
expect(currentState.equals(home, {locale:'nl_NL'})).toBe(true);

The history.go(-1) (when the user presses a back button) got bounced because it will be using an invalid locale. This example makes it more clear that state validation will be needed instead, though the suggestion seems to be very logical at first. I've got to rethink if there will be scenarios where this argument doesn't apply to.