Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --fail-only option to fail the test suite in CI when an it.only is left in #76

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

botandrose
Copy link

@botandrose botandrose commented Dec 18, 2024

I accidentally left an it.only in one of my recent commits, so CI was hamstrung without complaint. I think the presence of it.only should fail the CI build, to prevent this from happening again.

Two commits:

  1. Create the --fail-only command line argument plugin, and enable it for npm run ci. I expect this to fail CI, because there's currently an it.only in test/core.js.
  2. Remove the it.only and be green again.

@botandrose
Copy link
Author

Added a commit to document the option in TESTING.md

@1cg 1cg merged commit f735400 into bigskysoftware:main Dec 19, 2024
2 checks passed
@botandrose botandrose deleted the fail-only branch December 19, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants