You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the PR binsync/binsync#341 from @twizmwazin, BinSync was made compatible with PyInstaller. Most of this code will be replaced with yodalib (since the code moved here), so we need to get these changes into this repo.
An effort needs to be made to track down all these diffs made by the linked PR and apply the changes here. If @twizmwazin can also give us hints on how to check when something is PyInstaller compatible, we can attempt to test ourselves.
The text was updated successfully, but these errors were encountered:
Those changes weren't strictly about pyinstaller compatibility, they were just general lint fixes. But, they're still worth doing, Pyinstaller has a whacky import detection system and keeping them tidy does help reduce the probability of errors. When I have time I can set up the linting I used and make it part of the CI with pre-commit.
With the PR binsync/binsync#341 from @twizmwazin, BinSync was made compatible with PyInstaller. Most of this code will be replaced with yodalib (since the code moved here), so we need to get these changes into this repo.
An effort needs to be made to track down all these diffs made by the linked PR and apply the changes here. If @twizmwazin can also give us hints on how to check when something is PyInstaller compatible, we can attempt to test ourselves.
The text was updated successfully, but these errors were encountered: