Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with new BinSync updates #4

Open
mahaloz opened this issue Nov 14, 2023 · 1 comment
Open

Align with new BinSync updates #4

mahaloz opened this issue Nov 14, 2023 · 1 comment
Labels

Comments

@mahaloz
Copy link
Member

mahaloz commented Nov 14, 2023

With the PR binsync/binsync#341 from @twizmwazin, BinSync was made compatible with PyInstaller. Most of this code will be replaced with yodalib (since the code moved here), so we need to get these changes into this repo.

An effort needs to be made to track down all these diffs made by the linked PR and apply the changes here. If @twizmwazin can also give us hints on how to check when something is PyInstaller compatible, we can attempt to test ourselves.

@twizmwazin
Copy link
Contributor

Those changes weren't strictly about pyinstaller compatibility, they were just general lint fixes. But, they're still worth doing, Pyinstaller has a whacky import detection system and keeping them tidy does help reduce the probability of errors. When I have time I can set up the linting I used and make it part of the CI with pre-commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants