Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic issue with NTFY_PASSWORD on pass-change? #1253

Open
pixitha opened this issue Jan 6, 2025 · 0 comments
Open

Logic issue with NTFY_PASSWORD on pass-change? #1253

pixitha opened this issue Jan 6, 2025 · 0 comments
Labels
🪲 bug Something isn't working

Comments

@pixitha
Copy link

pixitha commented Jan 6, 2025

🐞 Describe the bug
I have ntfy running in a docker container (fly.io) and was adding a 2nd user via terminal inside of the docker container. Running the change-pass function with the ntfy server client was never asking for a password. I didn't realize that I had set the ENV variable for this, to run on the initial setup, but after the initial setup it never gets used. This created a silent failure (on my part) that whenever I try to change any user password, it always uses the original ENV variable.

💻 Components impacted
ntfy server/user auth

💡 Screenshots and/or logs

ntfy user change-pass testuser
changed password for user testuser

This leads to a slightly confusing silent password change, it might be worth adding some output to the user.go code to reflect when its using the env variable, since it can be a bit confusing why its not prompting for the password like you would expect?

🔮 Additional context

@pixitha pixitha added the 🪲 bug Something isn't working label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant