-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Showing
2 changed files
with
5 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
#!/bin/sh | ||
|
||
nimble --localdeps build -y --verbose -d:release | ||
chmod +x mosdepth | ||
mkdir -p "${PREFIX}/bin" | ||
cp mosdepth "${PREFIX}/bin/" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f58d4a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ramprasadn thanks for keeping this updated!
it seems this has broken the OSX build (brentp/mosdepth#171) .
Is there a way to have the OSX binary built with nimble?
1f58d4a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brentp Earlier versions of mosdepth available on bioconda lack the --d4 option, and I thought an easy fix would be just use the precompiled binary as is. I didn't expect the binaryfile to not work in OSX.
One solution I can think of is to have a build script that would install the precompiled binary in linux systems and build a binary with nimble in OSX. Would that be an acceptable solution in this case? What do you think?
1f58d4a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think that's a good solution.
1f58d4a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a PR ready for review here #33500 @brentp Please have a look at it and let me know what you think!