Skip to content

Commit

Permalink
Update mosdepth to v0.3.3 (#32708)
Browse files Browse the repository at this point in the history
* install from exec

* build noarch
  • Loading branch information
ramprasadn authored Feb 2, 2022
1 parent 8917270 commit 1f58d4a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 11 deletions.
2 changes: 1 addition & 1 deletion recipes/mosdepth/build.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/sh

nimble --localdeps build -y --verbose -d:release
chmod +x mosdepth
mkdir -p "${PREFIX}/bin"
cp mosdepth "${PREFIX}/bin/"
14 changes: 4 additions & 10 deletions recipes/mosdepth/meta.yaml
Original file line number Diff line number Diff line change
@@ -1,26 +1,21 @@
{% set version = "0.3.3" %}
{% set sha256hash = "71edbefef8e3a43ddf41f79e24f4a11eb208e6fc0957e4431294a5e9517a3c14" %}
{% set sha256hash = "59d302d60037763d632ce7e5daa1300058d92a4eea92637b6f40047d0b1c56fd" %}

package:
name: mosdepth
version: {{ version }}

source:
- url: https://github.com/brentp/mosdepth/archive/v{{ version }}.tar.gz
- url: https://github.com/brentp/mosdepth/releases/download/v{{ version }}/mosdepth
sha256: {{ sha256hash }}

build:
number: 0
number: 1
noarch: generic

requirements:
build:
- {{ compiler('c') }}
- git
- nim
host:
- htslib
- htslib >=1.10
- pcre
run:

test:
Expand All @@ -33,7 +28,6 @@ about:
dev_url: https://github.com/brentp/mosdepth
doc_url: https://github.com/brentp/mosdepth
license: MIT
license_file: LICENSE
summary: 'Fast BAM/CRAM depth calculation for WGS, exome, or targetted sequencing.'

extra:
Expand Down

4 comments on commit 1f58d4a

@brentp
Copy link
Contributor

@brentp brentp commented on 1f58d4a Feb 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramprasadn thanks for keeping this updated!
it seems this has broken the OSX build (brentp/mosdepth#171) .
Is there a way to have the OSX binary built with nimble?

@ramprasadn
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brentp Earlier versions of mosdepth available on bioconda lack the --d4 option, and I thought an easy fix would be just use the precompiled binary as is. I didn't expect the binaryfile to not work in OSX.
One solution I can think of is to have a build script that would install the precompiled binary in linux systems and build a binary with nimble in OSX. Would that be an acceptable solution in this case? What do you think?

@brentp
Copy link
Contributor

@brentp brentp commented on 1f58d4a Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that's a good solution.

@ramprasadn
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a PR ready for review here #33500 @brentp Please have a look at it and let me know what you think!

Please sign in to comment.