-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acknowledge which query providers list DICOM meta-data #122
Comments
I will take the first approach while keeping the same behaviour if no specific configuration was given.
|
After the discussion, and agreement, I will only highlight the points for the record: |
The new configuration property |
#342 Makes it so that Dicoogle /search and /dump services acknowledge DICOM sources only. To complete this issue, we would need to integrate this to the remaining services (DICOM query/retrieve comes to mind). |
Indexer plugins exist to serve two key purposes:
With that in mind, we know that some indices will hold DICOM data, while others will not. Only the query providers that hold DICOM should be selected for operations such as retrieving DIM identifiers (StudyInstanceUID, SeriesInstanceUID, SOPInstanceUID), and all DICOM-specific protocols (Q/R, WADO, ...). However, right now there's no way to know where DICOM data is kept. Even if some query providers may understand our Lucene-based queries, they might not give us the intended results, and our DICOM service implementations could (in the worst case) fail against this situation.
The actual request: To have a means in the Dicoogle core to identify which of the query providers are DICOM providers. A few possible approaches:
QueryInterface
with a signature similar tobool providesDICOM()
, thus leaving the flag defined by the plugin itself, as it's meant to be. Unfortunately, this demands a change to the SDK, as well as existing plugins.Have any additional ideas? What do you think?
The text was updated successfully, but these errors were encountered: