Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Commit

Permalink
mkdir and browserify are installed with slush-biojs
Browse files Browse the repository at this point in the history
  • Loading branch information
@CarlosHorro
CarlosHorro committed Apr 13, 2016
1 parent eb4d09b commit ffe3c2a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 0 additions & 2 deletions inquirer.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,6 @@ inq.getDevDependencies = function(a) {
var devDependencies = {};

// default dependencies
devDependencies["mkdirp"] = "^0.5.0";

This comment has been minimized.

Sign in to view

Copy link
@ayusharma

ayusharma Apr 14, 2016

These dependencies helps in scaffolding of package.json . I think after removing them from here, slush will not include these in package.json. and generates an error as

 > mkdirp build && browserify -r ./:test-biojs -o build/biojs.js
sh: mkdirp: command not found

Please take a look. :)

This comment has been minimized.

Sign in to view

Copy link
@wilzbach

wilzbach Apr 14, 2016

Member

@CarlosHorro -1 (bad charma) for commiting without a PR!
thanks @ayusharma for keeping an eye!

@CarlosHorro why did you remove this?
devDependencies["browserify"] = "6.x";

if (a.coverage) {
devDependencies["blanket"] = "^1.1.6";
Expand Down
4 changes: 3 additions & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@
"rc": "^1.1.5",
"underscore": "^1.7.0",
"underscore.string": "^3.2.2",
"username": "^1.0.0"
"username": "^1.0.0",
"mkdirp": "0.5.0",
"browserify": "13.x"
},
"devDependencies": {},
"engines": {
Expand Down

4 comments on commit ffe3c2a

@CarlosHorro
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Seb

Sorry about committing without a PR.
I removed them because I though they were duplicated, as I installed my modified version of slush-biojs and they got installed without problems...

@wilzbach
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries - it's just a nice policy in the open source world, so that something like this doesn't happen :)

@ayusharma does it work again?

@ayusharma
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wilzbach It worked. I think we should revert the changes because it is not installing mkdirp. Could you also update the version of browserify and watchify to latest so it will slove the issue #15 .

@CarlosHorro
Copy link
Contributor Author

@CarlosHorro CarlosHorro commented on ffe3c2a Apr 26, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi all

What do you think about installing mkdirp with the script 'install' (as a post-install procedure)?
...
"scripts": {
"install" : "npm install -g mkdirp"
}
...
I checked that and it works...

Please sign in to comment.