[ENH] Preprocess - Use language from Corpus #963
Merged
+244
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
language-preprocess
branch
2 times, most recently
from
4342212 to
1d676a7
Compare
PrimozGodec
force-pushed
the
language-preprocess
branch
from
00d9e54 to
4206b70
Compare
PrimozGodec
force-pushed
the
language-preprocess
branch
9 times, most recently
from
d7ed75d to
56268bc
Compare
PrimozGodec
force-pushed
the
language-preprocess
branch
from
56268bc to
7190a98
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #963 +/- ##
==========================================
- Coverage 82.29% 82.23% -0.06%
==========================================
Files 93 93
Lines 12448 12481 +33
Branches 1699 1710 +11
==========================================
+ Hits 10244 10264 +20
- Misses 1893 1902 +9
- Partials 311 315 +4 |
PrimozGodec
force-pushed
the
language-preprocess
branch
from
7190a98 to
074b2de
Compare
PrimozGodec
force-pushed
the
language-preprocess
branch
from
074b2de to
00240df
Compare
|
/rebase |
biolab-helper
force-pushed
the
language-preprocess
branch
from
00240df to
8c15381
Compare
3 tasks
PrimozGodec
force-pushed
the
language-preprocess
branch
from
8c15381 to
6cd35a1
Compare
3 tasks
PrimozGodec
force-pushed
the
language-preprocess
branch
from
6cd35a1 to
ad52536
Compare
3 tasks
|
/rebase |
biolab-helper
force-pushed
the
language-preprocess
branch
from
ad52536 to
31d28cd
Compare
PrimozGodec
force-pushed
the
language-preprocess
branch
from
31d28cd to
4f088d8
Compare
3 tasks
PrimozGodec
force-pushed
the
language-preprocess
branch
2 times, most recently
from
f90e4ea to
723e44b
Compare
3 tasks
PrimozGodec
force-pushed
the
language-preprocess
branch
from
723e44b to
392232c
Compare
3 tasks
PrimozGodec
force-pushed
the
language-preprocess
branch
4 times, most recently
from
dbd7af3 to
d22d1c5
Compare
VesnaT
reviewed
Apr 2, 2024
PrimozGodec
force-pushed
the
language-preprocess
branch
2 times, most recently
from
9a47c0c to
3be4d30
Compare
PrimozGodec
force-pushed
the
language-preprocess
branch
from
3be4d30 to
2c16beb
Compare
|
This draft is waiting for #1080 to be merged |
PrimozGodec
force-pushed
the
language-preprocess
branch
from
2c16beb to
1509420
Compare
|
@VesnaT, I reimplemented the logic. It is ready for review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Set language combo boxes for the language from the corpus.
Additionally, this PR changes the UDPIPE combo box to keep the same language when one wants to set language to language unavailable in UDPIPE. Previously, it was always reset to English.
Includes