[FIX] Make ReliefF and RReliefF results replicable #7026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markotoplak
force-pushed
the
relief-replicable-by-default
branch
from
4552268 to
041ff6d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7026 +/- ##
==========================================
- Coverage 88.36% 88.36% -0.01%
==========================================
Files 332 332
Lines 73345 73345
==========================================
- Hits 64814 64812 -2
- Misses 8531 8533 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
ReliefF and RReliefF had default random_seed set to
None. Therefore their results in Rank and Preprocess widgets could differ. I became aware of this when reviewing #7023.Description of changes
I just changed the default random_seed, so now ReliefF is replicable unless explicitly specified not to be.
It would be trivial to add random_seed arguments in some places, but the Rank and Preprocess would need slightly bigger refactoring, because the current code there does not allow easy adding of arguments to various scorers.
Includes