Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📎 Implement eslint/prefer-object-spread #4319

Open
Conaclos opened this issue Oct 17, 2024 · 5 comments
Open

📎 Implement eslint/prefer-object-spread #4319

Conaclos opened this issue Oct 17, 2024 · 5 comments
Assignees
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Comments

@Conaclos
Copy link
Member

Conaclos commented Oct 17, 2024

Description

Implement eslint/prefer-object-spread.

Want to contribute? Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide and analyzer contributing guide.

See also the related discussion.

Note: we have to decide if we name the rule noObjectAssign or useObjectSpread.
noObjectAssign could mean banning all calls to Object.assign (that is not intended by the rule we want to implement). Unfortunately, useObjectSpread could (should?) cover more cases - not sure the ones it could cover.

@Conaclos Conaclos added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Oct 17, 2024
@Conaclos
Copy link
Member Author

@kbkn3 Can I assign it to you?

@kbkn3
Copy link

kbkn3 commented Oct 17, 2024

@Conaclos
ok! I'll try.

@kbkn3
Copy link

kbkn3 commented Oct 28, 2024

Plan

  1. create scafold
  2. implements run()
  3. implements diagnostic()
  4. implements others

@kbkn3
Copy link

kbkn3 commented Oct 28, 2024

kbkn3#1

@ematipico
Copy link
Member

@kbkn3 you created the PR against your fork, which is wrong.

You have to create the PR against this repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

No branches or pull requests

3 participants