Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data locations #44

Open
florianhartig opened this issue Jun 27, 2018 · 4 comments
Open

data locations #44

florianhartig opened this issue Jun 27, 2018 · 4 comments

Comments

@florianhartig
Copy link
Member

we have to talk about the locations for the test data

I put the LPJ folder structure from Maurizio in tests. But there is also data-raw and inst/extdata

I would put data that is only used for the tests in the test folder, but not sure ...

@Rasilgon
Copy link
Collaborator

The files in inst/exdata are used by the vignette.

In data-raw I put the files/data and the script I used to create the package internal data. My understandings that any other data which is not used for internal data and it is not RData should be placed in inst/extdata (http://r-pkgs.had.co.nz/data.html#data-extdata)

I found: "Data for tests: it’s ok to put small files directly in your test directory. But remember unit tests are for testing correctness, not performance, so keep the size small."
So it seems that the test data could be in the test folder or extdata.

It seems that we do a correct use of the three folders: extdata, data-raw and test. As long as it causes no trouble we could keep as it is now, I think.

@florianhartig
Copy link
Member Author

inst/exdata and test is OK then (I would definitely keep data for tests in test)

data-raw - so this is the raw data that was used to create inst/exdata? Then this should be included in the buildignore, see http://r-pkgs.had.co.nz/data.html

@Rasilgon
Copy link
Collaborator

data-raw is used to create the internal package data (sysdata.rda) and the folder contains the script to generate sysdata.rda and all files required by the script.
It is include in my buildignore, but I have not pushed to the repo, but I will.

@Rasilgon
Copy link
Collaborator

Actually data-raw is already included in Rbuildignore https://github.com/biometry/rLPJGUESS/blob/master/rLPJGUESS/.Rbuildignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants