Faster czt #43
Closed
Faster czt #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
=======================================
Coverage 92.92% 92.93%
=======================================
Files 18 18
Lines 1018 1019 +1
=======================================
+ Hits 946 947 +1
Misses 72 72 ☔ View full report in Codecov by Sentry. |
roflmaostc
reviewed
Jun 20, 2024
| @@ -267,30 +269,38 @@ function czt_1d(xin, plan::CZTPlan_1D) | |||
| # which (intentionally) leads to non-real results for even-sized arrays at non-unit zoom | |||
|
|
|||
| L = size(plan.fft_fv, plan.d) | |||
| nsz = ntuple((dd) -> (dd==plan.d) ? L : size(xin, dd), Val(ndims(xin))) | |||
| nsz = ntuple((dd) -> (dd==plan.d) ? L : size(xin, dd), Val(D)) # sizes may vary per dimension, so a new array has to be generated | |||
| # append zeros | |||
| y = zeros(eltype(plan.aw), nsz) | |||
There was a problem hiding this comment.
If you want this CUDA runable, do
y = similar(xin, eltype(plan.aw), nsz)
fill!(y, 0)
In my code, I try to avoid zeros or ones.
| # corner = ntuple((x)->1, Val(ndims(xin))) | ||
| # select_region(xin .* plan.aw, new_size=nsz, center=corner, dst_center=corner) | ||
|
|
||
| # g = ifft(fft(y, d) .* plan.fft_fv, d) | ||
| g = plan.ifftw_plan * (plan.fftw_plan * y .* plan.fft_fv) | ||
| plan.fftw_plan! * y # in-place application to y |
There was a problem hiding this comment.
in general avoid comments behind lines, do better above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to speed up the czt performance. Also added support for arbitrary transform-dims.